From owner-freebsd-current@FreeBSD.ORG  Thu Aug  5 11:16:42 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 2FB5A16A4CE
	for <freebsd-current@freebsd.org>;
	Thu,  5 Aug 2004 11:16:42 +0000 (GMT)
Received: from eva.fit.vutbr.cz (eva.fit.vutbr.cz [147.229.10.14])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 769BD43D39
	for <freebsd-current@freebsd.org>;
	Thu,  5 Aug 2004 11:16:41 +0000 (GMT)
	(envelope-from xdivac02@stud.fit.vutbr.cz)
Received-SPF: pass (eva.fit.vutbr.cz: domain of xdivac02@eva.fit.vutbr.cz
	designates 127.0.0.1 as permitted sender) receiver=eva.fit.vutbr.cz;
	client_ip=127.0.0.1; envelope-from=xdivac02@eva.fit.vutbr.cz;
Received: from eva.fit.vutbr.cz (localhost [127.0.0.1])
	by eva.fit.vutbr.cz (8.12.11/8.12.11) with ESMTP id i75BGbeH029036
	(version=TLSv1/SSLv3 cipher=EDH-RSA-DES-CBC3-SHA bits=168 verify=NO);
	Thu, 5 Aug 2004 13:16:37 +0200 (CEST)
Received: (from xdivac02@localhost)
	by eva.fit.vutbr.cz (8.12.11/8.12.5/Submit) id i75BGbjY029035;
	Thu, 5 Aug 2004 13:16:37 +0200 (CEST)
Date: Thu, 5 Aug 2004 13:16:37 +0200
From: Divacky Roman <xdivac02@stud.fit.vutbr.cz>
To: Max Laier <max@love2party.net>
Message-ID: <20040805111637.GA29010@stud.fit.vutbr.cz>
References: <20040804125640.GA78633@stud.fit.vutbr.cz>
	<20040804130530.GA78973@stud.fit.vutbr.cz>
	<200408042003.07356.max@love2party.net>
	<20040805105048.GA28144@stud.fit.vutbr.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20040805105048.GA28144@stud.fit.vutbr.cz>
User-Agent: Mutt/1.4.2i
X-Scanned-By: MIMEDefang 2.16 (www . roaringpenguin . com / mimedefang)
cc: freebsd-current@freebsd.org
cc: Dan Cojocar <dan.cojocar@gmail.com>
Subject: Re: problems with altq
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 05 Aug 2004 11:16:42 -0000

On Thu, Aug 05, 2004 at 12:50:48PM +0200, Divacky Roman wrote:
> On Wed, Aug 04, 2004 at 08:03:00PM +0200, Max Laier wrote:
> > On Wednesday 04 August 2004 15:05, Divacky Roman wrote:
> > >                 struct pf_altq          *altq, *a;
> > >
> > >                 if (pa->ticket != ticket_altqs_inactive) {
> > >                         error = EBUSY;
> > >                         break;
> > >                 }
> > >                 altq = pool_get(&pf_altq_pl, PR_NOWAIT);
> > > 			         ^^^^^^^^^^
> > > shouldnt this be initalized to NULL? at least its not nice to have it
> > > uninitalized...
> > 
> > hum?
> > $ cd /usr/src/sys/contrib/pf/net && grep pf_altq_pl *
> > <...>
> > pf_ioctl.c:     pf_state_pl = pf_altq_pl = pf_pooladdr_pl = NULL;
> > pf_ioctl.c:     UMA_DESTROY(pf_altq_pl);
> > pf_ioctl.c:             UMA_CREATE(pf_altq_pl,    struct pf_altq, "pfaltqpl");
> > <...>
> > 
> > Or what are you thinking about?
> 
> pf/net/pf_ioctl.c:2032 and below 
> 
> hm... I got it wrong. I looked at it again and I changed type with variable
> name ;(
> 
> hysteria.sk/~neologism/NEOLOGISM is my kernel config
> hysteria.sk/~neologism/pf.conf is my whole pf config
> 
> I am compiling kernel with -Os (I know its not supported) I'll try with plain
> -O
>  
> btw: why does the malloc has to be NOWAIT?

kernel compiled with -O and M_WAITOK doesnt help either