From owner-cvs-all  Sat Jun 23 14: 4:50 2001
Delivered-To: cvs-all@freebsd.org
Received: from earth.backplane.com (earth-nat-cw.backplane.com [208.161.114.67])
	by hub.freebsd.org (Postfix) with ESMTP
	id 1933A37B401; Sat, 23 Jun 2001 14:04:45 -0700 (PDT)
	(envelope-from dillon@earth.backplane.com)
Received: (from dillon@localhost)
	by earth.backplane.com (8.11.3/8.11.2) id f5NL4j673973;
	Sat, 23 Jun 2001 14:04:45 -0700 (PDT)
	(envelope-from dillon)
Date: Sat, 23 Jun 2001 14:04:45 -0700 (PDT)
From: Matt Dillon <dillon@earth.backplane.com>
Message-Id: <200106232104.f5NL4j673973@earth.backplane.com>
To: Mikhail Teterin <mi@aldan.algebra.com>, jlemon@FreeBSD.ORG,
	cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/netinet tcp_subr.c
References: <200106231912.f5NJCUE01011@aldan.algebra.com> <200106232034.f5NKYwY73776@earth.backplane.com>
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-all.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20cvs-all>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20cvs-all>
X-Loop: FreeBSD.ORG

    (note: my original small_bzerol() function in the message before last
    had a bug)

: */
:static __inline void
:small_bzerol(void *s, int bytes)
:{
:    while (bytes > 0) {
:	*(int *)((char *)s + bytes) = 0;
:	bytes -= 4;
:    }
:}

    bzzt.  bytes -= 4 has to go before, not after.

    The one in my proposed kernel function is correct (and better).

						-Matt

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message