From owner-freebsd-fs@FreeBSD.ORG  Wed Jan 12 16:18:41 2011
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C47471065670;
	Wed, 12 Jan 2011 16:18:41 +0000 (UTC)
	(envelope-from stef@memberwebs.com)
Received: from thewalter.net (thewalter.net [94.75.203.97])
	by mx1.freebsd.org (Postfix) with ESMTP id 8BD3C8FC1B;
	Wed, 12 Jan 2011 16:18:41 +0000 (UTC)
Received: from [172.17.182.217] (adsl-75-12-188-41.dsl.pltn13.sbcglobal.net
	[75.12.188.41]) by thewalter.net (Postfix) with ESMTPA id 7D63E36817;
	Wed, 12 Jan 2011 16:18:39 +0000 (UTC)
Message-ID: <4D2DD45C.7050406@memberwebs.com>
Date: Wed, 12 Jan 2011 08:18:36 -0800
From: Stef Walter <stef@memberwebs.com>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US;
	rv:1.9.2.13) Gecko/20101208 Thunderbird/3.1.7
MIME-Version: 1.0
To: Pawel Jakub Dawidek <pjd@FreeBSD.org>
References: <4D2B8616.4000503@memberwebs.com> <4D2B89C4.8080300@memberwebs.com>
	<20110111214619.GF1812@garage.freebsd.pl>
	<4D2D0941.40002@memberwebs.com>
	<20110112072213.GG1812@garage.freebsd.pl>
In-Reply-To: <20110112072213.GG1812@garage.freebsd.pl>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: freebsd-fs@freebsd.org
Subject: Re: 'zfs list' does abort in make_dataset_handle
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 12 Jan 2011 16:18:41 -0000

On 01/11/2011 11:22 PM, Pawel Jakub Dawidek wrote:
> On Tue, Jan 11, 2011 at 05:52:01PM -0800, Stef Walter wrote:
>> On 01/11/2011 01:46 PM, Pawel Jakub Dawidek wrote:
>>> On Mon, Jan 10, 2011 at 02:35:48PM -0800, Stef Walter wrote:
>>>> On 01/10/2011 02:20 PM, Stef Walter wrote:
>>>>> After a failed zfs receive, zfs list now aborts in make_dataset_handle()
>>>>> in libzfs.so.2.
>>>>
>>>> The following patch suppresses the problem, and may give a clear
>>>> indication of how the problem manifests.
>>>
>>> I'd more threat such situation as if dds_inconsistent would be true and
>>> destroy/rollback offending dataset. Could you try something like that?
>>
>> Sounds like a good plan. Attached is a patch which does that.
> 
> But does it fix your problem?

Yup, it does.

Stef