From nobody Fri Feb 6 17:59:28 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4f720c6X56z6RVsH for ; Fri, 06 Feb 2026 17:59:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4f720c3ShBz4KZd for ; Fri, 06 Feb 2026 17:59:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770400768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AUeNDKZfS87NATMSui1zYS1l2r4XHkpBXTB3ROQoj5o=; b=gehJ/wP3/5SnGvihE8LcpKUGD+oWIoFlZcLyu+gIrTTtDisSpZyG0GDaUxk16ukA7uum06 y3tMMD9VX1maBWsin8G+V96r2ZrdjtbpHcl1FhsUVcaEG5jLTlBw1ZWRL05dKyTGOW6U4T 43iJVBBWPFNkqwNeMxC46F/vSL1C64fTu54J4mXxph9i+0Et2L9beayvyhMu7CXsQ+w8Yt BEjb2DGHQhBQbE0Iq4Z9lcEd0hpLTdvkawqtYnn8t7WiNyx6qezU3oCtUdr45F5LMpy29t KgG7IZ0KVjPV92oHJrkSF8udxyJvPK73gVt6ShIHtlGLiKfnxd1qRGPp+sv6YQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1770400768; a=rsa-sha256; cv=none; b=ItSCFLiGyszLiK6ujxhozysoaQB2b6B/Dtddgp4w5X4m2PHIIl1BYR9mzzqoC2+9Na8sp4 URiXPTVTUIpCxwNS9oR+D67oiPjXmlYtXSDGfhdpoJMeRIcQFx/1z1dAzhfFKwY7UnqmrG Sc0j0rYNSPbsrL5q41l4JJ64h7PTD6tCk0fS0BZ5MJaFR/LxZ333QPmWgpY4jAgfSzvmn6 g6ynOySDbiMrGcfzcAglXTCYMPbMFyEwfYMUAvMtHDyAm+gUg26oz5dqi4jf/Ca26hzwD2 RYyGxbI3EvwvFd+2P08LyxCORKNj2WkDuoNhzFx5gR/zcq1hXvpbLjPhZSYmig== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1770400768; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AUeNDKZfS87NATMSui1zYS1l2r4XHkpBXTB3ROQoj5o=; b=OEGfMDWA/kskggJSfVvljPRceb2mcexTjRw+x/tK+pw8ObaNv2yBXDvHZM2SNiLl4Lln0v fZ1XG+tXoec+8XK33RJ04eSrBbnmeqRybg23Fbchy/SIlTWaqS/3SduL52/qfRMU84azwk qzYWDjkLQxOOggc+98mekXJTmaXV7dgkvjcP4m9XJIHpaWo9le/l/YmXpR6SeipGETXOWZ 35FwKHLYxbX4YcQ56JQEQOKkx88m7WXeiig6xkMS81Qh+iriZTEcNb5ouLar0D+pWxHdzG iHqfSUKtzJ3M22YwVPkomnJ/1uTSZ746mN4S3SHWuyNzcofPh6czKR2tnBUvRg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4f720c2h88z9sx for ; Fri, 06 Feb 2026 17:59:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2694a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 06 Feb 2026 17:59:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Zhenlei Huang Subject: git: f250852c9a0c - main - qlnxe: Fix setting the unicast MAC filter of RX path List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: f250852c9a0c1021c3be4b498e27cfc7b42a81db Auto-Submitted: auto-generated Date: Fri, 06 Feb 2026 17:59:28 +0000 Message-Id: <69862c00.2694a.6c8ab9e@gitrepo.freebsd.org> The branch main has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=f250852c9a0c1021c3be4b498e27cfc7b42a81db commit f250852c9a0c1021c3be4b498e27cfc7b42a81db Author: Zhenlei Huang AuthorDate: 2026-02-06 17:52:53 +0000 Commit: Zhenlei Huang CommitDate: 2026-02-06 17:52:53 +0000 qlnxe: Fix setting the unicast MAC filter of RX path When an Ethernet interface is added to lagg(4) as a child interface, its type, aka if_type, is changed from IFT_ETHER to IFT_IEEE8023ADLAG. Well changing the link-layer address of the lagg(4) interface will be propagated to all child interfaces, hence the drivers of child interfaces shall not presume the type of the interface will not be changed. Meanwhile, on initializing, an ifnet has been fully attached and it is guaranteed to have non-null link-layer address so stop NULL checking for it. Reviewed by: kbowling Fixes: 792226e53023 qlnxe: Allow MAC address override MFC after: 5 days Differential Revision: https://reviews.freebsd.org/D54885 --- sys/dev/qlnx/qlnxe/qlnx_os.c | 16 +++------------- 1 file changed, 3 insertions(+), 13 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index 1c885133c3ec..ec2fd7cacfae 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -7057,20 +7057,10 @@ qlnx_set_rx_mode(qlnx_host_t *ha) int rc = 0; uint8_t filter; const if_t ifp = ha->ifp; - const struct ifaddr *ifa; - struct sockaddr_dl *sdl; - ifa = if_getifaddr(ifp); - if (if_gettype(ifp) == IFT_ETHER && ifa != NULL && - ifa->ifa_addr != NULL) { - sdl = (struct sockaddr_dl *) ifa->ifa_addr; - - rc = qlnx_set_ucast_rx_mac(ha, ECORE_FILTER_REPLACE, LLADDR(sdl)); - } else { - rc = qlnx_set_ucast_rx_mac(ha, ECORE_FILTER_REPLACE, ha->primary_mac); - } - if (rc) - return rc; + rc = qlnx_set_ucast_rx_mac(ha, ECORE_FILTER_REPLACE, if_getlladdr(ifp)); + if (rc) + return rc; rc = qlnx_remove_all_mcast_mac(ha); if (rc)