Date: Mon, 30 Mar 2020 11:51:40 -0600 From: Ian Lepore <ian@freebsd.org> To: Thomas Skibo <thomas-bsd@skibo.net>, freebsd-arm@freebsd.org Subject: Re: 64-bit extensions for Cadence if_cgem.c driver. Message-ID: <3a62d50a338eb34dade74afc8a4fc556fcfbb754.camel@freebsd.org> In-Reply-To: <20200330174505.GA1561@bentley> References: <20200330174505.GA1561@bentley>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 2020-03-30 at 10:45 -0700, Thomas Skibo wrote: > > Hello. > > I have been working on 64-bit extensions to the Cadence GEM Ethernet > driver > (dev/cadence/if_cgem.c). The GEM is used not only in the Zynq > platform but > also the Zynq UltraScale+ and the SiFve Highfive Unleashed (riscv) > platforms. > I finally got hardware that let me test the driver on a Zynq > UltraScale. (I > have an Ultra96 board with a 96B four-port Ethernet mezzanine card.) > > It will need a bit more testing but I think I am ready to put it up > for review on phabricator. But, I have also fixed up a lot of style > and > white-space issues in the driver. Does it make sense to submit those > changes > first as a separate review before putting my functional changes up on > phabricator? > > Or should I submit it all at once? > > Thanks, > --Thomas If you have the style changes separate from the functional changes already, it would be good to get those out of the way first, then the diffs for the functional changes will be much easier to read and review. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3a62d50a338eb34dade74afc8a4fc556fcfbb754.camel>