From owner-svn-src-head@freebsd.org Thu Mar 30 23:11:59 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1E710D26AE3; Thu, 30 Mar 2017 23:11:59 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from mail.strugglingcoder.info (strugglingcoder.info [104.236.146.68]) by mx1.freebsd.org (Postfix) with ESMTP id 0DFC7772; Thu, 30 Mar 2017 23:11:58 +0000 (UTC) (envelope-from hiren@strugglingcoder.info) Received: from localhost (unknown [10.1.1.3]) (Authenticated sender: hiren@strugglingcoder.info) by mail.strugglingcoder.info (Postfix) with ESMTPA id 1089117699; Thu, 30 Mar 2017 16:11:59 -0700 (PDT) Date: Thu, 30 Mar 2017 16:11:58 -0700 From: hiren panchasara To: "Somayajulu, David" Cc: David C Somayajulu , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r316309 - head/sys/dev/qlxgbe Message-ID: <20170330231158.GI1016@strugglingcoder.info> References: <201703302243.v2UMhX2s011405@repo.freebsd.org> <20170330230227.GH1016@strugglingcoder.info> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ljn2+zwPkKedfiv/" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 23:11:59 -0000 --ljn2+zwPkKedfiv/ Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03/30/17 at 11:07P, Somayajulu, David wrote: > Hi Hiren, > > I know this is not a new topic but a little more descriptive commit-log= would have been nicer. Also, you should update the manpage reflecting this= change. i.e. now it also supports software LRO when h/w LRO is disabled. > Will do. Sorry about that. Thanks! >=20 > > Do you know of a case where one would want to disable h/w lro and enabl= e s/w lro? I guess where you want to free up nic and make cpu do more work? > I was under the impression as well, that s/w lro is moot, if h/w lro was = available, till one costumer asked for it. Not sure what the use case is. I thought this idea (like gro in linux) was popular when lro in h/w was considered buggy and couldn't correctly do batching (i.e. hide useful flags). Not sure if that's still the case. cheers, Hiren --ljn2+zwPkKedfiv/ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQF8BAABCgBmBQJY3ZC+XxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lCgQH/jfRoG25lozt00G2gitCANGU BA99S8nGiUq2VvmPnTDgs5tagyCn4XU3vpj8kXklUFXEZIByE/+t1QcwTsmYktHe MJd/bRDMj4FaLi5G+4bI02T1GsbiyI+XzKDXYL5MvLD508LBcScMh9MBIjWyAV4i EF9YrXIQc7EvQu2s5UjJb2zEjz8J6NOrUOBIRkzB54Xfczgz+7I7BcjU+hcAIquM Bbj2b7Yf/njm50NgyB/VOXDYiJ7uagscohkbl2YkQ6mzqLrtFPm0VekFtWfUlOW2 PsTNMgiN5DzUrq8ZeqdgU4nJS3BZcwOu7a05ykqZyq3lCBneT93xiN2NbDDzmws= =bbC6 -----END PGP SIGNATURE----- --ljn2+zwPkKedfiv/--