From owner-svn-src-head@freebsd.org Thu Jun 14 00:01:53 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 90DEE1003E61; Thu, 14 Jun 2018 00:01:53 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2D27B83BDF; Thu, 14 Jun 2018 00:01:53 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (unknown [127.0.1.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by freefall.freebsd.org (Postfix) with ESMTPS id EFD301D1E8; Thu, 14 Jun 2018 00:01:52 +0000 (UTC) (envelope-from bdrewery@FreeBSD.org) Received: from mail.xzibition.com (localhost [172.31.3.2]) by mail.xzibition.com (Postfix) with ESMTP id ECEC87CD9; Thu, 14 Jun 2018 00:01:51 +0000 (UTC) X-Virus-Scanned: amavisd-new at mail.xzibition.com Received: from mail.xzibition.com ([172.31.3.2]) by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new, port 10026) with LMTP id Lf8YqJdobzY0; Thu, 14 Jun 2018 00:01:49 +0000 (UTC) To: Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org DKIM-Filter: OpenDKIM Filter v2.10.3 mail.xzibition.com A0D837CD1 References: <201806130852.w5D8qKd4094584@repo.freebsd.org> From: Bryan Drewery Openpgp: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Autocrypt: addr=bdrewery@FreeBSD.org; prefer-encrypt=mutual; keydata= xsBNBFJphmsBCADiFgmS4bIzwZijrS31SjEMzg+n5zNellgM+HkShwehpqCiyhXdWrvH6dTZ a6u50pbUIX7doTR7W7PQHCjCTqtpwvcj0eulZva+iHFp+XrbgSFHn+VVXgkYP2MFySyZRFab D2qqzJBEJofhpv4HvY6uQI5K99pMqKr1Z/lHqsijYYu4RH2OfwB5PinId7xeldzWEonVoCr+ rfxzO/UrgA6v/3layGZcKNHFjmc3NqoN1DXtdaEHqtjIozzbndVkH6lkFvIpIrI6i5ox8pwp VxsxLCr/4Musd5CWgHiet5kSw2SzNeA8FbxdLYCpXNVu+uBACEbCUP+CSNy3NVfEUxsBABEB AAHNJEJyeWFuIERyZXdlcnkgPGJkcmV3ZXJ5QEZyZWVCU0Qub3JnPsLAgAQTAQoAKgIbAwUL CQgHAwUVCgkICwUWAwIBAAIeAQIXgAIZAQUCWujOIgUJCmB7NwAKCRA113G7bkaXz/xpB/9b /UWIPbieY1IeIuHF2pyYPE7Hytkh3HVsxMA0F5Ma2AYQsXZZeKNKWrF7RPyDyDwUklLHJkhm k3EfClBbHxf08kMIm1vWCJRtgxic9knY/bzYGiWMpHjg3cSd1XfrYH1autYqTZAjDwIkgOjU dR//Tbn4V36sY7y2jz+kdMVWvK53U32aZqiwBbCn4DPe1wSZcUs17mV/0uZdIoGdj74B1orN A/0py5vHYo6HcbBNoaR8pKRLf5VZNRsxqGIMhTucx4SJWcHpuRBWYyvJSFzwvxdK4ZD4Yqoc kFGPVtOXktVMai9exrLvP3G77fKMu8DI6j4QRU4wCesnHuIfRPFuzsBNBFJphmsBCACiVFPf kNfaFtUSuY0395ueo/rMyHPGPQ2iwvERFCpeFGSQSgagpenNHLpFQKTg/dl6FOoST5tqyxMq fyHGHDzzU51bvA/IfaGoNi/BIhTe/toZNMRvpcI3PLjiGcnJnuwCCbAVOAGdb+t5cZtpNdOI cKYmrYG3u9RiBpe6dTF+qLrD/8Bs1wjhduQ8fcNNgnkXu8xDH4ZxY0lIc3QgvYWp9vimlQe6 iKjUd2/DX28ETZcD5h6pYV331KMPTrEI0p0yvFijUZce8c1XHFyL1j9sBAha5qpszJl6Uq5i LolhKRcGfcdmtD72vHQjUYglUyudSJUVyo2gMYjdbiFKzJulABEBAAHCwGUEGAEKAA8CGwwF AlrozigFCQpgez0ACgkQNddxu25Gl8+m5Af/R3VEdxNMAcDIes9ADhQyofj20SPV3eCJ3HYR OebTSuNdOudGt4AAyA8Ks94u9hiIp5IGsc6RDsT9W7O2vgXhd6eV3eiY5Oif5xLIYrIDVu1Y 1GyRxRrPEn/QOqDN6uFZCPwK1aOapGcYCrO9lB0gMuTVfgHanU61rgC9tMX0OoAOyRd+V3/M 8lDNhjJdF/IpO3SdYzKfkwduy4qamw4Gphcx/RfYQvYLq/eDkP8d50PphWdboqWBwNRHayro W/07OGzfxM5fJ5mBsXPQcO2QcRjkyHf6xCM6Hi1qQL4OnXMNE/ZTX0lnOj1/pH93TlzSHZMP TaiiA/MBD3vGsXBmBg== Organization: FreeBSD Subject: Re: svn commit: r335042 - head/usr.bin/top Message-ID: <9b6b26cf-dac2-f5ab-e694-5d132ff1bdb9@FreeBSD.org> Date: Wed, 13 Jun 2018 17:01:35 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201806130852.w5D8qKd4094584@repo.freebsd.org> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9Wgrtzixcze6qfAfp5yWRGyOKAXaxSvc2" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Jun 2018 00:01:54 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --9Wgrtzixcze6qfAfp5yWRGyOKAXaxSvc2 Content-Type: multipart/mixed; boundary="ATlQM6y8g3RNle56kKvDtVw76tSh0GFat"; protected-headers="v1" From: Bryan Drewery To: Eitan Adler , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <9b6b26cf-dac2-f5ab-e694-5d132ff1bdb9@FreeBSD.org> Subject: Re: svn commit: r335042 - head/usr.bin/top References: <201806130852.w5D8qKd4094584@repo.freebsd.org> In-Reply-To: <201806130852.w5D8qKd4094584@repo.freebsd.org> --ATlQM6y8g3RNle56kKvDtVw76tSh0GFat Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/13/2018 1:52 AM, Eitan Adler wrote: > Author: eadler > Date: Wed Jun 13 08:52:19 2018 > New Revision: 335042 > URL: https://svnweb.freebsd.org/changeset/base/335042 >=20 > Log: > top(1): add myself to authors > =20 > At this point I've mucked enough with top(1) that all bugs should be > blamed on me rather than William LeFebvre. >=20 Thank you for all of your work here... There's not exactly a guideline for this but I don't feel that non-functional changes qualify as "authors". Especially the sorting chosen. Perhaps I missed some rewrite you've done? Though none have 'Relnotes: yes' so I am assuming they were all non-functional. There's been 62 unique committers to usr.bin/top, which does not account for Submitted By. All of which are also missing from AUTHORS and Copyrigh= ts. I do see some people adding their Copyright on some commits but overall we haven't done that as a project and I am curious if we should change in that regard. Also I really abhor rewriting anything that's not broken as it causes merge conflict pain downstream and just adds regression risk. > Modified: > head/usr.bin/top/top.1 > head/usr.bin/top/utils.c >=20 > Modified: head/usr.bin/top/top.1 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/top/top.1 Wed Jun 13 08:52:17 2018 (r335041) > +++ head/usr.bin/top/top.1 Wed Jun 13 08:52:19 2018 (r335042) > @@ -360,6 +360,7 @@ process is waiting. > Lock names are prefixed with an asterisk \*(lq*\*(rq while sleep event= s > are not. > .Sh AUTHORS > +.An Eitan Adler Aq Mt eadler@FreeBSD.org > .An William LeFebvre, EECS Department, Northwestern University > .Sh BUGS > The command name for swapped processes should be tracked down, but thi= s >=20 > Modified: head/usr.bin/top/utils.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/usr.bin/top/utils.c Wed Jun 13 08:52:17 2018 (r335041) > +++ head/usr.bin/top/utils.c Wed Jun 13 08:52:19 2018 (r335042) > @@ -2,6 +2,7 @@ > * This program may be freely redistributed, > * but this entire comment MUST remain intact. > * > + * Copyright (c) 2018, Eitan Adler > * Copyright (c) 1984, 1989, William LeFebvre, Rice University > * Copyright (c) 1989, 1990, 1992, William LeFebvre, Northwestern Uni= versity > * >=20 --=20 Regards, Bryan Drewery --ATlQM6y8g3RNle56kKvDtVw76tSh0GFat-- --9Wgrtzixcze6qfAfp5yWRGyOKAXaxSvc2 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJbIbBrAAoJEDXXcbtuRpfPnw4H/3sf5fNiUbb7aeLwQIXNs9k/ oBPKHDX+iNW0MP7HIDPJKFAg7lkC2Tnxkld0HpV2W/Tijp/JLgWc0lBTiEfdVDk0 /Z5Bl/zaQm9fml8p9CIeK3eJTorptcO883aKFVK8veMdMb0QwMpfsGBWu+MYAxKq ykvRgsDlH/IU1Ja/ird7+/VqF1iyGCSYQffZ/RXr2IIsv6lFtrQ9G5ytCQSG0RYJ MY13gI8n0Lpnp0J5YGeZ11qOmr6u8Em25XLdHO4Xaj1aTRPT5RgcN9rVRogCSv41 6aB8I+e3WHmuNcqJXvuSOyUdGO/elEDDQrC36m/XdJkJeMmHRc9Se3xYgPBoT7E= =3k1a -----END PGP SIGNATURE----- --9Wgrtzixcze6qfAfp5yWRGyOKAXaxSvc2--