From owner-svn-src-head@freebsd.org Sat Jun 27 03:04:19 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 40AF43406E5; Sat, 27 Jun 2020 03:04:19 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg1-x52e.google.com (mail-pg1-x52e.google.com [IPv6:2607:f8b0:4864:20::52e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 49tz9t5bKpz4DdK; Sat, 27 Jun 2020 03:04:18 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg1-x52e.google.com with SMTP id e9so5806149pgo.9; Fri, 26 Jun 2020 20:04:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6mfUE7j5yE35YrMsXeSK3hqZMoMGsV6y/IFxtF7jWZk=; b=lQRI4WzmqtqJ6zBPLjffJdqDt1w8Yvj1e//sMIpWeMT4ha/rUUuPIa1udFxrMnbwBV UfrAPcHz1iM5c2d0x9X4z+KMMMdxkH1e9rAWyLaF06nVHrgkAsYaMq9okTMuUyONV/l7 7hmdy50tRxKU3/5xlrGVxR+fhnURn2wo4QAd9NpNLSEFlwIZ3ymhLP3C+eV11Dn7R9sc 8vXK+C6QJN2pyA8OXir7Z6bFBby6J/uAuRbT0tkKyz5KB5HU+UdaJAzIvwe+UkeUvoRp Yiq6zAUAjEiq2O9npdB2Bveu7HrzKpiLuZwTHjjmnBZrFT/TzFIXEprsmC9w7l2xdofN t91A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=6mfUE7j5yE35YrMsXeSK3hqZMoMGsV6y/IFxtF7jWZk=; b=qelG2vG2j9QEJDZxfwBNID8uLIsHy1VSI1EdhniQ+rrJD/rjaGO6lE0J+oZ5wDn2Ma l2VFgMJfvU4GvAlSSf+HeMeimrOX7x4hc9L8p8a1e5T7QpHiLhUb8kDR4fzk7vc8xjzE cOzgSXeYh94fan1vYLmsUucIBxrEv7X4VJkbCprPzjdDuh55jzwrMSmW6tV4SSPx5qYy GC8FzeGtGFZPjabBbkGCA1eEDR3JZDLTgsouABakIPlx1wgJj8Bcycbaxe40i+QHfyxq r6XHsOnX+Cdjoa03Xi2yQGYLAe2jRXpDkiTKrsIw3hZv2LjlULSheVW9scJZffgi2cx2 +0eg== X-Gm-Message-State: AOAM532GHxLLaQaBNm77ifDz987ygzdXm2lRSTtQOwDX7DyjtJ8MGC2d TDl5AUIwuMIFSOur3dcSYsiBEaFFtvs= X-Google-Smtp-Source: ABdhPJxWxtMlHMeReaV3LMcOo9btf8ZbEAXJB8+EKlQTcPJCVWft5NWYJx/0+3zR/yZCicGchReggA== X-Received: by 2002:aa7:924c:: with SMTP id 12mr5250783pfp.225.1593227057146; Fri, 26 Jun 2020 20:04:17 -0700 (PDT) Received: from [192.168.20.26] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id g140sm16728889pfb.48.2020.06.26.20.04.16 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 26 Jun 2020 20:04:16 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Re: svn commit: r362667 - head/sys/cddl/contrib/opensolaris/uts/common/dtrace From: Enji Cooper In-Reply-To: <20200627010206.GA63841@FreeBSD.org> Date: Fri, 26 Jun 2020 20:04:15 -0700 Cc: Matt Macy , src-committers , svn-src-all , svn-src-head Content-Transfer-Encoding: quoted-printable Message-Id: <94C5CFE0-2F25-44FA-B0B7-D6397D4EAC7A@gmail.com> References: <202006270057.05R0vmgC070914@repo.freebsd.org> <20200627010206.GA63841@FreeBSD.org> To: Alexey Dokuchaev X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Rspamd-Queue-Id: 49tz9t5bKpz4DdK X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US]; REPLY(-4.00)[] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jun 2020 03:04:19 -0000 > On Jun 26, 2020, at 6:02 PM, Alexey Dokuchaev = wrote: >=20 > On Sat, Jun 27, 2020 at 12:57:48AM +0000, Matt Macy wrote: >> New Revision: 362667 >> URL: https://svnweb.freebsd.org/changeset/base/362667 >>=20 >> Log: >> Fix "current" variable name conflict with openzfs >>=20 >> The variable "current" is an alias for curthread >> in openzfs. Rename all variable uses of current >> in dtrace.c to curstate. >=20 > Shouldn't OpenZFS be fixed instead? The fact that we need to fix our > local variables suggests that they're abusing too generic name=E2=80=A6 I kind of agree with `current` being a bit too genericly named = in both DTrace and OpenZFS :/.. Cheers, -Enji