Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 21 Jan 2012 01:27:12 -0500
From:      Eitan Adler <eadler@freebsd.org>
To:        Bruce Evans <brde@optusnet.com.au>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, Hiroki Sato <hrs@freebsd.org>, src-committers@freebsd.org
Subject:   Re: svn commit: r230354 - head/usr.sbin/makefs
Message-ID:  <CAF6rxgk5xkpz3JoLi03efEsWccwya-ECAPXpOJVJqir6uQyMMQ@mail.gmail.com>
In-Reply-To: <20120121164200.I2292@besplex.bde.org>
References:  <201201200138.q0K1cSou016739@svn.freebsd.org> <20120120.123256.1432718473132856309.hrs@allbsd.org> <20120121103348.Q1254@besplex.bde.org> <CAF6rxg=UH23TreEMzgZVxO_3GB%2B-K3EL02hOSG2DUb0=V-7UBg@mail.gmail.com> <20120121164200.I2292@besplex.bde.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Jan 21, 2012 at 12:52 AM, Bruce Evans <brde@optusnet.com.au> wrote:
> On Fri, 20 Jan 2012, Eitan Adler wrote:
>
>> On Fri, Jan 20, 2012 at 7:13 PM, Bruce Evans <brde@optusnet.com.au> wrot=
e:
>>>
>>> I agree. =C2=A0Never fix vendor code. =C2=A0Especially style bugs in it=
. =C2=A0Not all
>>> vendor code is in contrib.
>> I'm sure this is a silly question, but why isn't this utility in a
>> contrib/ folder?
> Probably historical, but src/contrib/ still has little more than `file'
> and lukemftpd from NetBSD. =C2=A0I think those are there mainly because t=
hey
> got portabilized and complicated by their use of autoconfig, so they
> don't fit naturally in the BSD build framework any more.

I'll check http://wiki.freebsd.org/ContribSoftware for now on before
making such fixes.

>>> I don't understand this code well enough to fix it. =C2=A0Fixing it req=
uires
>>> understanding whether the unused variable was unused because of another
>>> bug. =C2=A0Another bug seems likely here, since there is so much dead c=
ode.
>>> Or maybe I'm just confused, and the dead code is actually undead. =C2=
=A0It
>>> is complicated enough for this to be unclear.
>> I did not just rely on the compiler - I went through the code manually
>> to ensure it was correct.
>
> It can take too long to see correctness for an apparently-simple change.

I won't revert this commit because it doesn't seem to have broken
anything from the end user perspective, but I won't complain if a
future import causes a regression.

Thanks for your time!

--=20
Eitan Adler
Source & Ports committer
X11, Bugbusting teams



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAF6rxgk5xkpz3JoLi03efEsWccwya-ECAPXpOJVJqir6uQyMMQ>