From owner-svn-src-head@FreeBSD.ORG Sat Jan 21 06:27:46 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6AFB01065670; Sat, 21 Jan 2012 06:27:46 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 47AEF8FC17; Sat, 21 Jan 2012 06:27:44 +0000 (UTC) Received: by lahe6 with SMTP id e6so975804lah.13 for ; Fri, 20 Jan 2012 22:27:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:x-gm-message-state :content-type:content-transfer-encoding; bh=ld57SGBNomMJN14Mw1E6YUC2YdmUhd2mXj+aKO5OhhQ=; b=V49PZEP2yQ3yVaqFdXpAfuouu/RDFnnGQPZPjU37yVCinUTaE2UL4gm6zW7YxB47jj 5RJnolyAvGuc08cXQrd0SbUyRaHAmJq4ktMSWcwseE41OYSnzT3btd+8tng8G9SfKCq0 NPF949ZV17ihDZh9JRlU8sOoqKh/g+PHsooLQ= Received: by 10.112.100.199 with SMTP id fa7mr162334lbb.89.1327127263139; Fri, 20 Jan 2012 22:27:43 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.25.196 with HTTP; Fri, 20 Jan 2012 22:27:12 -0800 (PST) In-Reply-To: <20120121164200.I2292@besplex.bde.org> References: <201201200138.q0K1cSou016739@svn.freebsd.org> <20120120.123256.1432718473132856309.hrs@allbsd.org> <20120121103348.Q1254@besplex.bde.org> <20120121164200.I2292@besplex.bde.org> From: Eitan Adler Date: Sat, 21 Jan 2012 01:27:12 -0500 X-Google-Sender-Auth: V4C2du9ekJJuGdnKyrnc_psXX5I Message-ID: To: Bruce Evans X-Gm-Message-State: ALoCoQmj4i2nmZNJUG/hb0RmfBc4Sk4qf5msFEXg5fMgKSxPXm2rwysYw2YnQC6fU6RJLQGjf48t Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Hiroki Sato , src-committers@freebsd.org Subject: Re: svn commit: r230354 - head/usr.sbin/makefs X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jan 2012 06:27:46 -0000 On Sat, Jan 21, 2012 at 12:52 AM, Bruce Evans wrote: > On Fri, 20 Jan 2012, Eitan Adler wrote: > >> On Fri, Jan 20, 2012 at 7:13 PM, Bruce Evans wrot= e: >>> >>> I agree. =C2=A0Never fix vendor code. =C2=A0Especially style bugs in it= . =C2=A0Not all >>> vendor code is in contrib. >> I'm sure this is a silly question, but why isn't this utility in a >> contrib/ folder? > Probably historical, but src/contrib/ still has little more than `file' > and lukemftpd from NetBSD. =C2=A0I think those are there mainly because t= hey > got portabilized and complicated by their use of autoconfig, so they > don't fit naturally in the BSD build framework any more. I'll check http://wiki.freebsd.org/ContribSoftware for now on before making such fixes. >>> I don't understand this code well enough to fix it. =C2=A0Fixing it req= uires >>> understanding whether the unused variable was unused because of another >>> bug. =C2=A0Another bug seems likely here, since there is so much dead c= ode. >>> Or maybe I'm just confused, and the dead code is actually undead. =C2= =A0It >>> is complicated enough for this to be unclear. >> I did not just rely on the compiler - I went through the code manually >> to ensure it was correct. > > It can take too long to see correctness for an apparently-simple change. I won't revert this commit because it doesn't seem to have broken anything from the end user perspective, but I won't complain if a future import causes a regression. Thanks for your time! --=20 Eitan Adler Source & Ports committer X11, Bugbusting teams