From owner-p4-projects@FreeBSD.ORG Fri Feb 22 12:46:06 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 07F4F16A477; Fri, 22 Feb 2008 12:46:06 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id BE80B16A405; Fri, 22 Feb 2008 12:46:05 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from mail.semihalf.com (mail.semihalf.com [83.15.139.206]) by mx1.freebsd.org (Postfix) with ESMTP id 7A78513C45A; Fri, 22 Feb 2008 12:46:05 +0000 (UTC) (envelope-from raj@semihalf.com) Received: from localhost (unknown [127.0.0.1]) by mail.semihalf.com (Postfix) with ESMTP id DB47814331; Fri, 22 Feb 2008 13:54:47 +0100 (CET) Received: from mail.semihalf.com ([127.0.0.1]) by localhost (mail.semihalf.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 32682-05; Fri, 22 Feb 2008 13:54:46 +0100 (CET) Message-ID: <47BEC409.8020406@semihalf.com> Date: Fri, 22 Feb 2008 13:46:01 +0100 From: Rafal Jaworowski MIME-Version: 1.0 To: Marcel Moolenaar References: <200802220422.m1M4MFI5035030@repoman.freebsd.org> In-Reply-To: <200802220422.m1M4MFI5035030@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-2 Content-Transfer-Encoding: 7bit X-Virus-Scanned: by amavisd-new at semihalf.com Cc: Perforce Change Reviews Subject: Re: PERFORCE change 135937 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Feb 2008 12:46:06 -0000 Marcel Moolenaar wrote: > > Change 135937 by marcel@marcel_xcllnt on 2008/02/22 04:21:47 > > Unify > > Fork the conflicting HID0_TBEN into HID0_AIM_TBEN > and HID0_BOOKE_TBEN. Renbame the e500-specific > defines to include _BOOKE. > > None of these were actually used. > Just to clarify: HID regs (and their fields) are vendor-specific (Freescale) and not present on other Book-E compliant systems, for example, PPC440 do not have them, so I think those defines should rather keep reference to E500, 74XX and so on. We can straighten this out at some later stage: as we talked earlier, there's more areas (pmap to name the most important) that assume E500 and would not run on other Book-E variations OOTB right now. There's a bit of work involved to make this port more generic/layered, and I have it on my TODO list. Rafal