From owner-cvs-all@FreeBSD.ORG Thu Apr 3 01:44:09 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 1D24E37B401; Thu, 3 Apr 2003 01:44:09 -0800 (PST) Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by mx1.FreeBSD.org (Postfix) with ESMTP id C8F0343F75; Thu, 3 Apr 2003 01:44:05 -0800 (PST) (envelope-from ru@whale.sunbay.crimea.ua) Received: from whale.sunbay.crimea.ua (ru@localhost [127.0.0.1]) h339hvgg043823 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 3 Apr 2003 12:43:58 +0300 (EEST) (envelope-from ru@whale.sunbay.crimea.ua) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.12.9/8.12.8/Submit) id h339hvts043818; Thu, 3 Apr 2003 12:43:57 +0300 (EEST) (envelope-from ru) Date: Thu, 3 Apr 2003 12:43:57 +0300 From: Ruslan Ermilov To: Marcel Moolenaar Message-ID: <20030403094357.GA43282@sunbay.com> References: <200304030513.h335DR60079544@repoman.freebsd.org> <20030402231638.A81523@FreeBSD.org> <20030403055049.GA67232@dhcp01.pn.xcllnt.net> <20030403180026.A29934@gamplex.bde.org> <20030403085350.GA37174@sunbay.com> <20030403093800.GA68012@dhcp01.pn.xcllnt.net> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="cWoXeonUoKmBZSoM" Content-Disposition: inline In-Reply-To: <20030403093800.GA68012@dhcp01.pn.xcllnt.net> User-Agent: Mutt/1.5.4i cc: Juli Mallett cc: cvs-src@FreeBSD.org cc: src-committers@FreeBSD.org cc: cvs-all@FreeBSD.org cc: Bruce Evans Subject: Re: cvs commit: src/libexec/talkd announce.c extern.h print.c table.c talkd.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Apr 2003 09:44:09 -0000 --cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Apr 03, 2003 at 01:38:00AM -0800, Marcel Moolenaar wrote: > On Thu, Apr 03, 2003 at 11:53:50AM +0300, Ruslan Ermilov wrote: > > >=20 > > How's this bugfix? > >=20 > > %%% > > Index: bsd.sys.mk > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > RCS file: /home/ncvs/src/share/mk/bsd.sys.mk,v > > retrieving revision 1.12 > > diff -u -r1.12 bsd.sys.mk > > --- bsd.sys.mk 31 Mar 2003 13:10:51 -0000 1.12 > > +++ bsd.sys.mk 3 Apr 2003 08:48:40 -0000 > > @@ -25,7 +25,7 @@ > > . if ${WARNS} > 3 > > CFLAGS +=3D -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wshad= ow -Wcast-align > > . endif > > -. if ${WARNS} > 4 > > +. if ${WARNS} > 4 && !empty(CFLAGS:M-O*) && empty(CFLAGS:M-O0) > > CFLAGS +=3D -Wuninitialized > > . endif > > # BDECFLAGS > > %%% >=20 > Should work in most cases, but beware DEBUG_FLAGS. The above does not > catch the case where DEBUG_FLAGS is defined to something like "-O0 -g". > I think this is a reasonable use of DEBUG_FLAGS. >=20 > \begin{log} > dhcp01% setenv DEBUG_FLAGS "-O0 -g" > dhcp01% setenv CFLAGS -O > dhcp01% make > cc -O -mcpu=3Dpentiumpro -I/usr/local/src/fpi/cpu/.. -O0 -g -Wsystem-hea= ders -Werror -Wall -Wno-format-y2k -W -Wstrict-prototypes -Wmissing-prototy= pes -Wpointer-arith -Wreturn-type -Wcast-qual -Wwrite-strings -Wswitch -Wsh= adow -Wcast-align -Wuninitialized -c decode.c > cc1: warnings being treated as errors > cc1: warning: -Wuninitialized is not supported without -O > *** Error code 1 > \end{log}=20 >=20 I doubt you have really tried my patch. DEBUG_FLAGS becomes part of CFLAGS in bsd.{prog,lib}.mk, and bsd.sys.mk is only parsed after, so it covers this case too: # make devfs.o cc -O -pipe -march=3Dpentiumpro -Wsystem-headers -Werror -Wall -Wno-forma= t-y2k - W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type -W= cast- qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -Wuninitialized -c dev= fs.c # make DEBUG_FLAGS=3D-O0 devfs.o cc -O -pipe -march=3Dpentiumpro -O0 -Wsystem-headers -Werror -Wall -Wno-fo= rmat-y2 k -W -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wreturn-type= -Wca st-qual -Wwrite-strings -Wswitch -Wshadow -Wcast-align -c devfs.c Cheers, --=20 Ruslan Ermilov Sysadmin and DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age --cWoXeonUoKmBZSoM Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.1 (FreeBSD) iD8DBQE+jAJdUkv4P6juNwoRAq+QAJ41SAwaEX/wZeaOYgmPI9V2mJ+iPgCdFhLo ep9yez0OxJLvxrcLQeGk+Ig= =gv6O -----END PGP SIGNATURE----- --cWoXeonUoKmBZSoM--