From nobody Fri Jun 13 14:49:25 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bJj3B1MGPz5q5sd; Fri, 13 Jun 2025 14:49:26 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bJj3B0D8pz3SnL; Fri, 13 Jun 2025 14:49:26 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749826166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5fY+NPESaxiB8q10g/isP1a9/2gXj77cNbjgnLcdL0A=; b=J9XI2VMjMR6eVnndyNSEGR/44TTvW6X9lckqJGCGn5ebJlsjSqf9/CTKW74Gi5Qw5nik4V BQAHAIhWEqjEG8WBxqy/GvvabiAMSnj36W/AU8MA59Yh50iOF2DEF1iZR/UHQglEuY4bfh xbxCm40CoLtlUex0ECrsejJC58VGKA6GO9tKILOm1XbWqpngCQ+IIVfLWYt50rVlxw9oim X6B9MG4cu1/SR4UkNlnUy2WzH40Vw3q6vQ/S1uTFlzQRUxpMYfqidxeMSRB9GlYxJhu9b+ WiRg0p+9hsalrU47p0pQchGO0ogJfC06ohiYMCeq5OdNIBCycqh4wVZmJkZQEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1749826166; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=5fY+NPESaxiB8q10g/isP1a9/2gXj77cNbjgnLcdL0A=; b=ggfNlcS2likoOa0LUAtyUkKyV8uiTIOugdwImS7kAGHjjykoWqk09Ii+W8or33MU4N6uXE zZsnALR4SMutYdyb/yBLxC1bQgMW3+dkMUAxE1a6W/eINLCXUBFqb17OXRT7qcCYJlh13N MeqkTmglBIyKWPAgADIxenJDl4MXBqzLR8C9NhF/mAJbkM5bFyHKo9AClZn7uME5aQEluc CMVQXA2t9mIqigZl8ZUR9j+t28zkwG9pN/5oC+3d5LQi0GtiQJU47jHgZ+BVMXqlACbTo/ WzwHyKySbejBbhnN5pESlINywYI47wEky9suOxXwH0ECWyQOY3h7vcR09nEQrg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1749826166; a=rsa-sha256; cv=none; b=g/5nZRYotfVqEAkTSYWRaUXiXljLE5FDOEdzdfes5Aj2AnCDGPcWSODJXUjtwBKQ3CI9HP kEcC8LRF4ovc680C0d0eejONcLrBkGd9uIQQ3WhQ18Eyv8Htr9e4K/+ifNiiKKjzcPH3RA SxA42qCIvMxK2nakm3/xmvwAv7tK4SkMVTjLAwxZ+xJ2lg1HL4kf2UH9PQjICx/8+4rHWS n45wGxFt5AaXJgVfodvoHX4fCcf1vJkW/E/X1eqRCqC5rCZRhEeS4Iw+SmlGnQ0lI6zOQv jnU6SYHBFViR4TfCP7ElPMy6+uMBtZrF0ApZnQGTk0cMCNZg/QRZn5jnSpFhDQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bJj396vk2z11yg; Fri, 13 Jun 2025 14:49:25 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55DEnPju091030; Fri, 13 Jun 2025 14:49:25 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55DEnPgE091027; Fri, 13 Jun 2025 14:49:25 GMT (envelope-from git) Date: Fri, 13 Jun 2025 14:49:25 GMT Message-Id: <202506131449.55DEnPgE091027@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 4f7473d18a62 - main - qlnx: fix panic at startup List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4f7473d18a62077a218ac00817bae09a95b8cbcb Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=4f7473d18a62077a218ac00817bae09a95b8cbcb commit 4f7473d18a62077a218ac00817bae09a95b8cbcb Author: Kristof Provost AuthorDate: 2025-06-12 16:53:33 +0000 Commit: Kristof Provost CommitDate: 2025-06-13 14:48:51 +0000 qlnx: fix panic at startup While attaching the qlnx driver we can end up trying to call ifmedia functions before those are set up (through ether_ifattach() -> rtnl_handle_ifattach() -> dump_iface() -> get_operstate_ether() -> ifmedia_ioctl()). Postpone the ether_ifattach() until after the ifmedia setup. Reviewed by: markj,zlei Sponsored by: Rubicon Communications, LLC ("Netgate") Differential Revision: https://reviews.freebsd.org/D50819 --- sys/dev/qlnx/qlnxe/qlnx_os.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/sys/dev/qlnx/qlnxe/qlnx_os.c b/sys/dev/qlnx/qlnxe/qlnx_os.c index a984908abf34..05ec69a70dfe 100644 --- a/sys/dev/qlnx/qlnxe/qlnx_os.c +++ b/sys/dev/qlnx/qlnxe/qlnx_os.c @@ -2339,9 +2339,6 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) ha->primary_mac[5] = (rnd >> 16) & 0xFF; } - ether_ifattach(ifp, ha->primary_mac); - bcopy(if_getlladdr(ha->ifp), ha->primary_mac, ETHER_ADDR_LEN); - if_setcapabilities(ifp, IFCAP_HWCSUM); if_setcapabilitiesbit(ifp, IFCAP_JUMBO_MTU, 0); @@ -2396,6 +2393,9 @@ qlnx_init_ifnet(device_t dev, qlnx_host_t *ha) ifmedia_set(&ha->media, (IFM_ETHER | IFM_AUTO)); + ether_ifattach(ifp, ha->primary_mac); + bcopy(if_getlladdr(ha->ifp), ha->primary_mac, ETHER_ADDR_LEN); + QL_DPRINT2(ha, "exit\n"); return;