From owner-freebsd-current Tue Apr 30 13:24:43 1996 Return-Path: owner-current Received: (from root@localhost) by freefall.freebsd.org (8.7.3/8.7.3) id NAA03966 for current-outgoing; Tue, 30 Apr 1996 13:24:43 -0700 (PDT) Received: from godzilla.zeta.org.au (godzilla.zeta.org.au [203.2.228.19]) by freefall.freebsd.org (8.7.3/8.7.3) with SMTP id NAA03940 for ; Tue, 30 Apr 1996 13:24:36 -0700 (PDT) Received: (from bde@localhost) by godzilla.zeta.org.au (8.6.12/8.6.9) id GAA21324; Wed, 1 May 1996 06:21:03 +1000 Date: Wed, 1 May 1996 06:21:03 +1000 From: Bruce Evans Message-Id: <199604302021.GAA21324@godzilla.zeta.org.au> To: jkh@time.cdrom.com, wosch@cs.tu-berlin.de Subject: Re: Files installed to /etc, (was: review request) Cc: current@freebsd.org Sender: owner-current@freebsd.org X-Loop: FreeBSD.org Precedence: bulk >1. some Makefile use 'mv' without option '-f'. This may fail mv(1) > into interactive mode if you are not root and the destination > file is write protected. >$ touch a b; chmod 444 a b; /bin/mv a b >override r--r--r-- wosch/wheel for b? ;-(( Install usually has to be run by root so that it can chown the target, so this shouldn't be a problem. >Solution: a variable MV="mv -f" in sys.mk >2. Same problem for 'rm', use variable RM="rm -f"in sys.mk I'd prefer to avoid this (and to someday avoid my ECHO and INSTALL macros :-). >3. Wired /usr/share/mk/sys.mk. make -I do not change the > directory for sys.mk. We need this for ``make DESTDIR=/foo world'' > so /foo/usr/share/mk/sys.mk would be used. >Does someone test the following patch? >... >-#define _PATH_DEFSYSMK "/usr/share/mk/sys.mk" >+#define _PATH_DEFSYSMK "sys.mk" > #define _PATH_DEFSYSPATH "/usr/share/mk" I thought that you said this was only a temporary fix when we talked about it in private mail. What gets used if sys.mk is in "." and in paths specified by -I? I think ./sys/mk should only be used if "-I." is used. >4. A target for executable scripts Yes, this has been delayed too long. 5. A target for miscellaneous files. This has also been delayed too long. 6. Think about avoiding sed'iting scripts and miscellaneous files. Some GNUish makefiles are about 10 times as long as BSDish makefiles because they handling things more generally. Bruce