From owner-freebsd-mips@FreeBSD.ORG  Sun Mar 11 03:44:12 2012
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 299FF1065670
	for <freebsd-mips@freebsd.org>; Sun, 11 Mar 2012 03:44:12 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-pz0-f54.google.com (mail-pz0-f54.google.com
	[209.85.210.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 004AF8FC08
	for <freebsd-mips@freebsd.org>; Sun, 11 Mar 2012 03:44:11 +0000 (UTC)
Received: by dald2 with SMTP id d2so3765308dal.13
	for <freebsd-mips@freebsd.org>; Sat, 10 Mar 2012 19:44:11 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=cVfNUOwcYyRAg9FvZ2txq7s2FeA+vzTtCO1dCnWn/Qg=;
	b=UaVcT0hVLXUXa5gyfrN+F91FARwVNITBRgy2kUH9KsJkhQyKAQtqeDKweVP0NmCxIW
	sqPmmquGUJEpUq99IrU3H268omj2dGBDVE6Jg+vH/RJ5xblRE6K0f/ZT0N00wYBzYA4W
	nurhKF+919KZjNzN0YATidbasBxI95nw+1rMdkyAc+IG7U5iCfBmBiEWUUWpG09O93ks
	NLXNfkYcGixQ0ojaKq5jyvd4iH+SXSSU64CK/gRFI0SJfPBBXOdxZVkeFW9t9ymtNCUM
	owN5/8kntd3JKfo9CAk1ug4HlkJZ5c5o1USLFlHMroS4/JHmvaqctDYE799d3My2C/kI
	k+Kw==
MIME-Version: 1.0
Received: by 10.68.225.104 with SMTP id rj8mr12502974pbc.135.1331437451559;
	Sat, 10 Mar 2012 19:44:11 -0800 (PST)
Sender: adrian.chadd@gmail.com
Received: by 10.143.33.5 with HTTP; Sat, 10 Mar 2012 19:44:11 -0800 (PST)
In-Reply-To: <CAD44qMV=PEv3DFU7z1S=UhOYO3YMi7zqg7rsjn1zByTpN7ZxgA@mail.gmail.com>
References: <CAD44qMV=PEv3DFU7z1S=UhOYO3YMi7zqg7rsjn1zByTpN7ZxgA@mail.gmail.com>
Date: Sat, 10 Mar 2012 19:44:11 -0800
X-Google-Sender-Auth: 8CrsOht-yC2qJpBFIe6mcb8SqOE
Message-ID: <CAJ-VmomZiutERg4YcTDUCAOC9Wwx5Gsdei4E-iSvszAw6H81SQ@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: Patrick Kelsey <kelsey@ieee.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: freebsd-mips@freebsd.org
Subject: Re: [PATCH] MikroTik RB450G support
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
	<mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 11 Mar 2012 03:44:12 -0000

Hi!

Thanks for this!

The arge patch for board info should be something chip specific,
rather than always compiled in.

The board model thing should be an environment variable, rather than
hard-coded in the driver.  What's it needed for, anyway? Are the MAC
addresses reversed?

The MII speed thing is good, I've been wondering about adding more MII
config stuff to the ar71xx code. But we'll have to ensure it's set
correctly for the AR91xx and AR724x code.


Adrian