From owner-freebsd-ports Sat Mar 24 15:46:22 2001 Delivered-To: freebsd-ports@freebsd.org Received: from obsecurity.dyndns.org (adsl-63-207-60-43.dsl.lsan03.pacbell.net [63.207.60.43]) by hub.freebsd.org (Postfix) with ESMTP id 3688437B718 for ; Sat, 24 Mar 2001 15:46:20 -0800 (PST) (envelope-from kris@obsecurity.org) Received: by obsecurity.dyndns.org (Postfix, from userid 1000) id 2AA8B66CCD; Sat, 24 Mar 2001 15:46:09 -0800 (PST) Date: Sat, 24 Mar 2001 15:46:09 -0800 From: Kris Kennaway To: Alex Kapranoff Cc: ports@FreeBSD.ORG Subject: Re: Conditionalizing MACHINE_CPU checks Message-ID: <20010324154609.A42192@xor.obsecurity.org> References: <20010319091353.A4146@kapran.bitmcnit.bryansk.su> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-md5; protocol="application/pgp-signature"; boundary="4Ckj6UjgE2iN1+kY" Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20010319091353.A4146@kapran.bitmcnit.bryansk.su>; from kapr@acm.org on Mon, Mar 19, 2001 at 09:13:53AM +0300 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org --4Ckj6UjgE2iN1+kY Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Mar 19, 2001 at 09:13:53AM +0300, Alex Kapranoff wrote: > Good day to all. >=20 > Do I really need to wrap MACHINE_CPU tests (like ${MACHINE_CPU:Mmmx}) > inside ${OSVERSION} >=3D 500018 tests? It's also in RELENG_4 now, so you should use check for ${OSVERSION} >=3D 500018 || ( ${OSVERSION} < 500000 && ${OSVERSION} >=3D 43= 0000 ) > E.g. is it ok to do tests in this way: >=20 > .if defined(WITH_MMX) || ${MACHINE_CPU:Mmmx} > SRCS+=3D mmx.c > .elif ${ARCH} =3D=3D "i386" > @${ECHO_MSG} "You can define WITH_MMX to use MMX instructions" > .endif I'd prefer to keep it under an .if OSVERSION test, so it becomes easier to just chop out the .else section when we stop supporting systems older than ${OSVERSION} =3D=3D 430000 Kris --4Ckj6UjgE2iN1+kY Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.0.4 (FreeBSD) Comment: For info see http://www.gnupg.org iD8DBQE6vTHBWry0BWjoQKURAhuvAJ9BPpcgJrmZ1BoHRbxhFtDEUpCaFwCeNIlL EmnUZeFSgjJbwEqjk/O2aDk= =rlCz -----END PGP SIGNATURE----- --4Ckj6UjgE2iN1+kY-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message