From owner-freebsd-hackers@FreeBSD.ORG Tue Jul 10 07:40:46 2007 Return-Path: X-Original-To: freebsd-hackers@freebsd.org Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 9381416A421; Tue, 10 Jul 2007 07:40:46 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from redbull.bpaserver.net (redbullneu.bpaserver.net [213.198.78.217]) by mx1.freebsd.org (Postfix) with ESMTP id 3FC0813C45D; Tue, 10 Jul 2007 07:40:46 +0000 (UTC) (envelope-from alexander@leidinger.net) Received: from outgoing.leidinger.net (p54A571E0.dip.t-dialin.net [84.165.113.224]) by redbull.bpaserver.net (Postfix) with ESMTP id 45C422E28B; Tue, 10 Jul 2007 09:40:41 +0200 (CEST) Received: from webmail.leidinger.net (webmail.Leidinger.net [192.168.1.102]) by outgoing.leidinger.net (Postfix) with ESMTP id 0F63C5B4AB1; Tue, 10 Jul 2007 09:38:30 +0200 (CEST) Received: (from www@localhost) by webmail.leidinger.net (8.13.8/8.13.8/Submit) id l6A7cTjB091882; Tue, 10 Jul 2007 09:38:29 +0200 (CEST) (envelope-from Alexander@Leidinger.net) Received: from pslux.cec.eu.int (pslux.cec.eu.int [158.169.9.14]) by webmail.leidinger.net (Horde MIME library) with HTTP; Tue, 10 Jul 2007 09:38:29 +0200 Message-ID: <20070710093829.34mqbekao4wwww4s@webmail.leidinger.net> X-Priority: 3 (Normal) Date: Tue, 10 Jul 2007 09:38:29 +0200 From: Alexander Leidinger To: Christopher Davis References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; DelSp="Yes"; format="flowed" Content-Disposition: inline Content-Transfer-Encoding: quoted-printable User-Agent: Internet Messaging Program (IMP) H3 (4.1.4) / FreeBSD-7.0 X-BPAnet-MailScanner-Information: Please contact the ISP for more information X-BPAnet-MailScanner: Found to be clean X-BPAnet-MailScanner-SpamCheck: not spam, SpamAssassin (not cached, score=-14.823, required 8, BAYES_00 -15.00, DKIM_POLICY_SIGNSOME 0.00, RDNS_DYNAMIC 0.10, TW_II 0.08) X-BPAnet-MailScanner-From: alexander@leidinger.net X-Spam-Status: No X-Mailman-Approved-At: Tue, 10 Jul 2007 11:29:09 +0000 Cc: freebsd-hackers@FreeBSD.org, Ariff@FreeBSD.org, multimedia@FreeBSD.org Subject: Re: Audio driver template X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Jul 2007 07:40:46 -0000 Quoting Christopher Davis (from Mon, 9 Jul 2007 =20 11:47:14 -0700): > http://people.freebsd.org/~cg/template.c > > Thought I would take a look at the audio driver template as > part of my task to modernize drivers, soc2007. I would simplify > the read and write functions to avoid using the bus tag and > handle, but I'm not sure what else to do to bring it up to date. > > How else can it be improved? Putting it into the examples directory instead of having it on the =20 people's own pages would be an improvement (the developer handbook =20 needs to be changed to point to the examples directory then). And you should clarify what kind of improvements are valid for your =20 SoC work. Somehow I doubt that adding shiny new features (like hps =20 suggested) is part of the goal for your work. I think it's more like =20 bringing existing drivers up-to-par with currently available generic =20 driver interfaces, isn't it? I also think examples for suspend/resume stuff should be added. =20 /sys/dev/sound/pci/atiixp.c has suspend and resume methods if you want =20 an example. You could also review the locking, as it changed a little bit =20 recently, I think. Apart from the atiixp driver the envy42, emu10kx and HDA drivers can =20 also serve as examples for what is the most current in the sound =20 subsystem in FreeBSD. Maybe you can gain some more hints from them (I =20 think the template is not very up-to-date compared to them). The new mixer interface is not used yet in the drivers, so we don't =20 have examples at all for them. You could ask ryanb@FreeBSD.org (or on =20 multimedia@) about it. Ariff@FreeBSD.org (or multimedia@) can maybe help if you have some =20 questions regarding the drivers in the tree (maybe Ariff will answer =20 to your initial question anyway). Bye, Alexander. --=20 I guess the Little League is even littler than we thought. =09=09-- D. Cavett http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137