Date: Thu, 26 Feb 2015 13:22:53 -0800 From: hiren panchasara <hiren@strugglingcoder.info> To: Adrian Chadd <adrian@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r279300 - in head/sys: kern sys Message-ID: <20150226212253.GE95752@strugglingcoder.info> In-Reply-To: <201502252159.t1PLx3UQ053872@svn.freebsd.org> References: <201502252159.t1PLx3UQ053872@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--G6nVm6DDWH/FONJq Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 02/25/15 at 09:59P, Adrian Chadd wrote: > Author: adrian > Date: Wed Feb 25 21:59:03 2015 > New Revision: 279300 > URL: https://svnweb.freebsd.org/changeset/base/279300 >=20 > Log: > Remove taskqueue_start_threads_pinned(); there's noa generic cpuset ver= sion of this. > =20 > Sponsored by: Norse Corp, Inc. >=20 > Modified: > head/sys/kern/subr_taskqueue.c > head/sys/sys/taskqueue.h >=20 > Modified: head/sys/kern/subr_taskqueue.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/kern/subr_taskqueue.c Wed Feb 25 21:44:53 2015 (r279299) > +++ head/sys/kern/subr_taskqueue.c Wed Feb 25 21:59:03 2015 (r279300) > @@ -659,30 +659,6 @@ taskqueue_start_threads_cpuset(struct ta > return (error); > } > =20 > -int > -taskqueue_start_threads_pinned(struct taskqueue **tqp, int count, int pr= i, > - int cpu_id, const char *name, ...) > -{ > - cpuset_t mask; > - va_list ap; > - int error; > - > - /* > - * In case someone passes in NOCPU, just fall back to the > - * default behaviour of "don't pin". > - */ > - if (cpu_id !=3D NOCPU) { > - CPU_ZERO(&mask); > - CPU_SET(cpu_id, &mask); > - } > - > - va_start(ap, name); > - error =3D _taskqueue_start_threads(tqp, count, pri, > - cpu_id =3D=3D NOCPU ? NULL : &mask, name, ap); > - va_end(ap); > - return (error); > -} > - > static inline void > taskqueue_run_callback(struct taskqueue *tq, > enum taskqueue_callback_type cb_type) >=20 > Modified: head/sys/sys/taskqueue.h > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/sys/taskqueue.h Wed Feb 25 21:44:53 2015 (r279299) > +++ head/sys/sys/taskqueue.h Wed Feb 25 21:59:03 2015 (r279300) > @@ -74,10 +74,6 @@ int taskqueue_start_threads(struct taskq > const char *name, ...) __printflike(4, 5); > int taskqueue_start_threads_cpuset(struct taskqueue **tqp, int count, > int pri, cpuset_t *mask, const char *name, ...) __printflike(5, 6); > -int taskqueue_start_threads_pinned(struct taskqueue **tqp, int count, > - int pri, int cpu_id, const char *name, > - ...) __printflike(5, 6); > - > int taskqueue_enqueue(struct taskqueue *queue, struct task *task); > int taskqueue_enqueue_timeout(struct taskqueue *queue, > struct timeout_task *timeout_task, int ticks); > Can you please update the manpage if you haven't already? Cheers, Hiren --G6nVm6DDWH/FONJq Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQF8BAEBCgBmBQJU746tXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRBNEUyMEZBMUQ4Nzg4RjNGMTdFNjZGMDI4 QjkyNTBFMTU2M0VERkU1AAoJEIuSUOFWPt/lhvAH/3Usl4nWWCkYZw1dpq8jgg0t Jn8LRWChOq2vdpspRNI3vWAUGn1KPoFb6FSxJSh/Wibaskuw72CBueJ7P8BhuBuX PzFKzsR5xJjD9lWb8OkJxei5XYcPHOAzvN5xEjPKW/bAAXlAYJhM8f31HUFtoKVb 94ISlCUL1m4T0yp3vF1ce8iJxaIw5LPZptf2vBbzRW3QOmrv6zQSpHopFhaTr8Lm AfMvI1BweiR36SMPFRfFKsdBrKZiR+oXZDAw4V9nbOK++s6URbJVmFWghbnaoMCz khJhKxqK0pxx8XNP96aQtFoeMdsfhDtUPSXUZCbryFeuWjW3ORR7KWYa8XHF0i0= =IsFM -----END PGP SIGNATURE----- --G6nVm6DDWH/FONJq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150226212253.GE95752>