From owner-svn-ports-head@freebsd.org Wed Aug 22 07:25:44 2018 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4E176108FEC4; Wed, 22 Aug 2018 07:25:44 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id F355D870F0; Wed, 22 Aug 2018 07:25:43 +0000 (UTC) (envelope-from tobik@FreeBSD.org) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 4518E221D7; Wed, 22 Aug 2018 03:25:43 -0400 (EDT) Received: from web5 ([10.202.2.215]) by compute4.internal (MEProxy); Wed, 22 Aug 2018 03:25:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=XW6GEL aytngM9NGzRBxz8q+pi/SSlocache8xNnaCsc=; b=Y99m/jD5VcHXiVeTvtE0aS YBNyuaZhMUQEK5k8MvR7hUEV21RsuD68IMknJcR6GylTSxIZ/Ot1qbIpHwtT2OxE Ev9peG3wD9sEB+H/sgMsOZNF3Ao40G9IgJDUEO108l6cj9gZGmisuMoARB12mU7B w19Z9HvGLMWvjGW5VQwckzWfca2d7vfCBCPllLuHKCQRdx32yq4RGRU5zjBy/O5f bisaB0HGNc/ly/CEh3PYpvgusNn1Lw0VZz5J+M7R/X9aKs6nnDbGSdbbsutL9XlX bXZo4rEffurJ8a7198LtivDEQx2rkW6fU+7Ko9qTzGPbO1jqM+klhlq634dUZ39A == X-ME-Proxy: X-ME-Sender: Received: by mailuser.nyi.internal (Postfix, from userid 99) id C5AFC9E257; Wed, 22 Aug 2018 03:25:42 -0400 (EDT) Message-Id: <1534922742.673192.1482199456.404603FB@webmail.messagingengine.com> From: Tobias Kortkamp To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="utf-8" X-Mailer: MessagingEngine.com Webmail Interface - ajax-7b72137a References: <201808211617.w7LGHbVa018387@repo.freebsd.org> <20180822070034.nmyni3ogxuqaok7j@atuin.in.mat.cc> Subject: Re: svn commit: r477722 - head/print/magicfilter In-Reply-To: <20180822070034.nmyni3ogxuqaok7j@atuin.in.mat.cc> Date: Wed, 22 Aug 2018 09:25:42 +0200 X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 07:25:44 -0000 On Wed, Aug 22, 2018, at 09:00, Mathieu Arnold wrote: > On Tue, Aug 21, 2018 at 04:17:37PM +0000, Tobias Kortkamp wrote: > > Author: tobik > > Date: Tue Aug 21 16:17:36 2018 > > New Revision: 477722 > > URL: https://svnweb.freebsd.org/changeset/ports/477722 > > > > Log: > > print/magicfilter: Prevent ccache from being accidentally added as a run dependency > > > > PR: 218268 > > Submitted by: Andreas Hollmann > > > > Modified: > > head/print/magicfilter/Makefile > > > > Modified: head/print/magicfilter/Makefile > > ============================================================================== > > --- head/print/magicfilter/Makefile Tue Aug 21 15:56:20 2018 (r477721) > > +++ head/print/magicfilter/Makefile Tue Aug 21 16:17:36 2018 (r477722) > > @@ -3,7 +3,7 @@ > > > > PORTNAME= magicfilter > > PORTVERSION= 2.3.h > > -PORTREVISION= 8 > > +PORTREVISION= 9 > > CATEGORIES= print > > MASTER_SITES= http://www.pell.portland.or.us/~orc/Code/magicfilter/ > > > > @@ -22,7 +22,7 @@ CONFIGURE_ENV+= LOCALBASE=${LOCALBASE} > > > > .if exists(${LOCALBASE}/lib/libmagic.so) > > BUILD_DEPENDS+= ${LOCALBASE}/lib/libmagic.so:sysutils/file > > -RUN_DEPENDS+= ${BUILD_DEPENDS} > > +RUN_DEPENDS:= ${BUILD_DEPENDS} > > .endif > > I do not know what happens before this, but it would probably be more > right to have: > > RUN_DEPENDS+= ${LOCALBASE}/lib/libmagic.so:sysutils/file The current form was suggested by bredwery@ in the PR, but I may have misinterpreted his comment a little. I've changed it back to how the original submission was.