From owner-freebsd-ports Mon Oct 27 21:24:58 1997 Return-Path: Received: (from root@localhost) by hub.freebsd.org (8.8.7/8.8.7) id VAA27173 for ports-outgoing; Mon, 27 Oct 1997 21:24:58 -0800 (PST) (envelope-from owner-freebsd-ports) Received: from scanner.worldgate.com (scanner.worldgate.com [198.161.84.3]) by hub.freebsd.org (8.8.7/8.8.7) with ESMTP id VAA27161 for ; Mon, 27 Oct 1997 21:24:50 -0800 (PST) (envelope-from marcs@znep.com) Received: from znep.com (uucp@localhost) by scanner.worldgate.com (8.8.7/8.8.7) with UUCP id WAA10033 for ports@FreeBSD.ORG; Mon, 27 Oct 1997 22:24:47 -0700 (MST) Received: from localhost (marcs@localhost) by alive.znep.com (8.7.5/8.7.3) with SMTP id WAA13179 for ; Mon, 27 Oct 1997 22:28:09 -0700 (MST) Date: Mon, 27 Oct 1997 22:28:09 -0700 (MST) From: Marc Slemko To: ports@FreeBSD.ORG Subject: Re: Port problem. In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-ports@FreeBSD.ORG X-Loop: FreeBSD.org Precedence: bulk ...and this change does, of course, violate RFC-1738 (RFC for URLs). However, not making this change violates RFC-959 (RFC for ftp). Sigh. What's a poor programmer to do. On Mon, 27 Oct 1997, Marc Slemko wrote: > It is arguable if the double // is valid to have there or not > and what Apache should be doing with it; there are a zillion specs > covering this and they all interact, so finding an exact answer > would be difficult. > > What Apache is doing is sending a "CWD " for the empty component > of the path. That is arguable incorrect, or at least not as good > as it could be. > > Below is a patch to Apache fix it. Likely won't apply directly to 1.2, > but you get the idea. I will see if people agree that it should go into > the 1.3 tree and, if so, I will commit it. > > This can, of course, be fixed by not having the double // there in the > first place, but thats another matter. It is also, of course, not a > solution if you can't play with the proxy. > > Index: modules/proxy/proxy_ftp.c > =================================================================== > RCS file: /export/home/cvs/apachen/src/modules/proxy/proxy_ftp.c,v > retrieving revision 1.40 > diff -u -r1.40 proxy_ftp.c > --- proxy_ftp.c 1997/09/30 21:02:14 1.40 > +++ proxy_ftp.c 1997/10/28 04:20:40 > @@ -626,6 +629,10 @@ > *strp = '\0'; > > len = decodeenc(path); > + if (len == 0) { > + path = strp + 1; > + break; > + } > bputs("CWD ", f); > bwrite(f, path, len); > bputs("\015\012", f); >