From nobody Thu May 2 17:14:41 2024 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VVgXd5wc9z5Jgrf; Thu, 2 May 2024 17:14:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VVgXd5Rjjz4bw2; Thu, 2 May 2024 17:14:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714670081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rD/THgTZyvLap/Jn+RV1j9HbW4MDYIMIsIK0mIuIujg=; b=YygZbg+bJhvdxrQPbsxz/7qfDihW4dVQ1nUysQYl6W5iWGTLOtT+jq++CtOeYajd/KX/gC 7lBFPV2qRcqeT2R65eDel883+W7NQ5lX+8rhD6xpvyJc8tVp45SWGp8a0UFIGw8DjDtKw3 P2mT+GzbfVbGjUOUBu3Yxhdz8BO1Wou4LwKekutbjLF6ktMFa66YrzTgKmROROs+tGBJ0X sbVP6Mglv2j4DZtn/Ia43VadQyKquz7ClQvcK7Yv8hQNnpDKu9QUgpJ6uX0+JsaW4k4gng AAHJcqXS+NXXLRWe2NWwUTi2DqbdrP713BW0tzqwuIJGSrKlFwbL1iORkqdwCw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1714670081; a=rsa-sha256; cv=none; b=Rr8NxnlYKZZ9FbBuUg7i4IhtFrcqjdIqsq0tGW0LSZIrifvFrLTG2EoZQMkYxAoY28ESHh YLH4Y/V2i5TRRDAp9OOLKh29zbkDwNUrbxA2nuyN8aoPwOK8N0Zj94DXXEyxz7jDlJPatO 9zdDxxLZncLDAT+/Sj/cDVX/DOA80GOgKDemkH6X5kIhMNCDXup7R9l0Cge7EkJbx+zc7p 6/CaSw67eozKs84AypQuxaMeLW7SOg5RZL+fZPxlZZMOGRX3lnsXgpe9j1EQh8IEldNguh vsnmr1TNqWJHGyvPsyNddsQonk3xrBMWoIiK22wFJO/Pzq0xqCLXbC/xKazjfQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1714670081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=rD/THgTZyvLap/Jn+RV1j9HbW4MDYIMIsIK0mIuIujg=; b=WHKmwhiaMM9xnGtJAlJxPVn6Yu/CvPjMeYWOGv3oGn11T7cSaI8MYHyskwIkEFBc7zDMH/ 5CGu1/5DmToHgscaKhCcoFHisTpQv0zi5fVK9vZ1wBWXDZVm5iV6mdndHxsXCvNGNKk/Vw 02aiFW5TfWbxFzHwxu3XsjRLY22+cHjFQvm14Z0gmd9Kfd9hj9Z+AnvKD+O2lyQm7BlztB vMrXpx0OZ30JShgHwu2RAlwp731ueirNdxYD0dwDCmoiMR/Utz9fhB0xr1PODNGR25iBZZ f+SP4gPUv0qVFGM55pKkt6ez33FOgms3imS/Iyi/gPD3R6DFrThQDe7BWa0rig== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VVgXd4mKhz19MP; Thu, 2 May 2024 17:14:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 442HEfSw069353; Thu, 2 May 2024 17:14:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 442HEfHZ069350; Thu, 2 May 2024 17:14:41 GMT (envelope-from git) Date: Thu, 2 May 2024 17:14:41 GMT Message-Id: <202405021714.442HEfHZ069350@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Brooks Davis Subject: git: 4510f2ca9170 - main - Make WITHOUT_UNDEFINED_VERSION the default List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: brooks X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 4510f2ca9170927309a423274e03f1eb8e27da27 Auto-Submitted: auto-generated The branch main has been updated by brooks: URL: https://cgit.FreeBSD.org/src/commit/?id=4510f2ca9170927309a423274e03f1eb8e27da27 commit 4510f2ca9170927309a423274e03f1eb8e27da27 Author: Brooks Davis AuthorDate: 2024-05-02 17:13:39 +0000 Commit: Brooks Davis CommitDate: 2024-05-02 17:13:39 +0000 Make WITHOUT_UNDEFINED_VERSION the default Link with --no-undefined-version by default. Will detect and prevent the accidental removal of symbols from versioned libraries. Reviewed by: arichardson, kib, dim, emaste Differential Revision: https://reviews.freebsd.org/D44216 --- share/man/man5/src.conf.5 | 10 ++++++---- share/mk/bsd.opts.mk | 4 ++-- tools/build/options/WITHOUT_UNDEFINED_VERSION | 2 -- tools/build/options/WITH_UNDEFINED_VERSION | 4 ++++ 4 files changed, 12 insertions(+), 8 deletions(-) diff --git a/share/man/man5/src.conf.5 b/share/man/man5/src.conf.5 index 5301fc488021..53d42321799b 100644 --- a/share/man/man5/src.conf.5 +++ b/share/man/man5/src.conf.5 @@ -1,5 +1,5 @@ .\" DO NOT EDIT-- this file is @generated by tools/build/options/makeman. -.Dd April 23, 2024 +.Dd May 1, 2024 .Dt SRC.CONF 5 .Os .Sh NAME @@ -1716,9 +1716,11 @@ and that the runtime support library is available Do not build .Xr unbound 8 and related programs. -.It Va WITHOUT_UNDEFINED_VERSION -Link libraries with --no-undefined-version to ensure all symbols are -provided. +.It Va WITH_UNDEFINED_VERSION +Link libraries with --undefined-version which permits version maps to +contain symbols that are not present in the library. +If this is necessicary to build a particular configuration, a bug is +present and the configuration should be reported. .It Va WITHOUT_UNIFIED_OBJDIR Use the historical object directory format for .Xr build 7 diff --git a/share/mk/bsd.opts.mk b/share/mk/bsd.opts.mk index 38d53cc6bf30..65ae4f4cfa7c 100644 --- a/share/mk/bsd.opts.mk +++ b/share/mk/bsd.opts.mk @@ -68,7 +68,6 @@ __DEFAULT_YES_OPTIONS = \ SSP \ TESTS \ TOOLCHAIN \ - UNDEFINED_VERSION \ WARNS \ WERROR @@ -81,7 +80,8 @@ __DEFAULT_NO_OPTIONS = \ PROFILE \ RETPOLINE \ STALE_STAGED \ - UBSAN + UBSAN \ + UNDEFINED_VERSION __DEFAULT_DEPENDENT_OPTIONS = \ MAKE_CHECK_USE_SANDBOX/TESTS \ diff --git a/tools/build/options/WITHOUT_UNDEFINED_VERSION b/tools/build/options/WITHOUT_UNDEFINED_VERSION deleted file mode 100644 index 0e58eb00f3c1..000000000000 --- a/tools/build/options/WITHOUT_UNDEFINED_VERSION +++ /dev/null @@ -1,2 +0,0 @@ -Link libraries with --no-undefined-version to ensure all symbols are -provided. diff --git a/tools/build/options/WITH_UNDEFINED_VERSION b/tools/build/options/WITH_UNDEFINED_VERSION new file mode 100644 index 000000000000..71b048349a6f --- /dev/null +++ b/tools/build/options/WITH_UNDEFINED_VERSION @@ -0,0 +1,4 @@ +Link libraries with --undefined-version which permits version maps to +contain symbols that are not present in the library. +If this is necessicary to build a particular configuration, a bug is +present and the configuration should be reported.