From owner-svn-src-all@freebsd.org Wed May 4 00:01:49 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6B4CCB2B257 for ; Wed, 4 May 2016 00:01:49 +0000 (UTC) (envelope-from andy@fud.org.nz) Received: from mail-yw0-x234.google.com (mail-yw0-x234.google.com [IPv6:2607:f8b0:4002:c05::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2F88519B8 for ; Wed, 4 May 2016 00:01:49 +0000 (UTC) (envelope-from andy@fud.org.nz) Received: by mail-yw0-x234.google.com with SMTP id g133so48145507ywb.2 for ; Tue, 03 May 2016 17:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fud-org-nz.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc; bh=dtQ7PeX6P2NoCLGV+kEhG2WIIypT+4/XTSCCC03RcHU=; b=R/M194svn3Hfxh9umn6sYQxEBGACxSipWxFAH0f4EZ1mLHDsKUm14exmUs9SQhMMNs FuL/DQEy1VxDi2tnSs3FeKdqLheRM3bIPNUM6gyn0DUaM2NDrAzUpo3kNWQAmM3kAZfX CDhn2BnrvW7CxVkzLjk9cNRcrb9OsURY5ZI7SytB+c2toyrg9N80CwpMc1EGhU5kwxJl /VN/N+n3LYSs2/IAFg8BaXa+Wtlgd5CE/+RESz/YXdoK+XJz4pRxs/ydgohJcgZhj6L4 kJ0FgTa+/KgVCPoi8hKAAEDpwAn8g6aAKGLDo8vy9E6zW2tKwybmMK3S5FoXxCjZcAlf vnbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc; bh=dtQ7PeX6P2NoCLGV+kEhG2WIIypT+4/XTSCCC03RcHU=; b=a8hvSCV/etAf+XJJ7ndhmEzBEp4uqf8Au8UJBdtPMdtzdszioDaw81n4GoYX+uX+4P RampE3XexsyWVhgHxXQ/skMi31hQZNMrXdv0co0L6df0oksxHre3O4aX/DpNkXfDujAQ ZAjrnQLSsg27A9BNTAIOR46GidRqxKyzAoWJ3bAxMKqgdjBxz5lngc2PPN/8DR+myNaA H0jy7o/Oc9uOUTBj2cSesFkZiyR2JvG9jTrTaki0njQigEXZykiwOOSMVV9OMhbKNkoL irzQyX6cAkeAPA9K2LlXl4XlsmGDSmDYoTEw7+Nn5IETHb2ClP758Lnfwok0OjqaxtsC odTA== X-Gm-Message-State: AOPr4FUo0ckS5MgTAuboCOaKiPvlROxbCq2pkOYoOg8aoCOFBUpPSvQrGNq9dYFW36Er2G3/cjmyniPTXfDLsg== MIME-Version: 1.0 X-Received: by 10.37.35.214 with SMTP id j205mr3083625ybj.178.1462320108377; Tue, 03 May 2016 17:01:48 -0700 (PDT) Received: by 10.129.125.193 with HTTP; Tue, 3 May 2016 17:01:48 -0700 (PDT) In-Reply-To: <201604281327.u3SDRCIa035707@repo.freebsd.org> References: <201604281327.u3SDRCIa035707@repo.freebsd.org> Date: Wed, 4 May 2016 12:01:48 +1200 Message-ID: Subject: Re: svn commit: r298743 - in head/sys/netinet: . tcp_stacks From: Andrew Thompson To: Randall Stewart Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.22 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 04 May 2016 00:01:49 -0000 On 29 April 2016 at 01:27, Randall Stewart wrote: > Author: rrs > Date: Thu Apr 28 13:27:12 2016 > New Revision: 298743 > URL: https://svnweb.freebsd.org/changeset/base/298743 > > Log: > This cleans up the timers code in TCP to start using the new > async_drain functionality. This as been tested in NF as well as > by Verisign. Still to do in here is to remove all the old flags. They > are currently left being maintained but probably are no longer needed. > > Sponsored by: Netflix Inc. > Differential Revision: http://reviews.freebsd.org/D5924 > > Modified: > head/sys/netinet/tcp_stacks/fastpath.c > head/sys/netinet/tcp_subr.c > head/sys/netinet/tcp_timer.c > head/sys/netinet/tcp_timer.h > head/sys/netinet/tcp_var.h > > Modified: head/sys/netinet/tcp_stacks/fastpath.c > > ============================================================================== > --- head/sys/netinet/tcp_stacks/fastpath.c Thu Apr 28 13:00:40 2016 > (r298742) > +++ head/sys/netinet/tcp_stacks/fastpath.c Thu Apr 28 13:27:12 2016 > (r298743) > @@ -2386,7 +2386,6 @@ struct tcp_function_block __tcp_fastslow > NULL, > NULL, > NULL, > - NULL, > 0, > 0 > > @@ -2403,7 +2402,6 @@ struct tcp_function_block __tcp_fastack > NULL, > NULL, > NULL, > - NULL, > 0, > 0 > }; > Is there a reason not to use named struct initialisers here? It is self-describing and also does not require the nulls to be set. ie { .tfb_tcp_output = tcp_output , ... } cheers, Andrew