From nobody Wed Jun 24 00:03:40 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4glMbf1y2hz6h8JZ; Wed, 24 Jun 2026 00:03:42 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4glMbd5fNcz3hhx; Wed, 24 Jun 2026 00:03:41 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782259421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O4lH9eASnZpQ5ugOGXzViAFk8+XHWHjlrIFyV4PU7Vc=; b=coOhVLOUMQQsmZeFl3Tmypn3uQBkxFs0KsyoTolSzwdossjxu1h7HbOyHXOCiOdqGaQeeD BxrGxGbwyFtTknQx8Nb+sC8s0ihAW7F//y7XLKiM2P4mG9Gdy2e6Q41shnnO6K6zFp7d8Q XuiioyVX0NiDMVXmksUNBBaIUoKchYDvdAb+8NXp2P5CcSlcGEr9/nPzw7sJgFvrwdkkwe dQ0FH5vDw1cg1StZxtOK7n0M97FLaeGLNspLC3bhVL56CPkMrLvn/B6Yt8C8MTOZfb1Csa QI/06YKLPPWjGYaWDNDfLRM/oH9qk2pyECy0tTalKynybB/Z03kHd7Cqek/4Nw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1782259421; a=rsa-sha256; cv=none; b=pVkadipDLvaAHcFkdTosvfLFLwNrAx57tw3wmgICRc8r6ggrg8Vva5927ctJamxDbff6tn AtMihSn6rbyyv65+3jOozowUzpEZ5ulalzOx+sDzM0UC+cqMCg3Q/V6kuZz2c5XabCNw4R VHb6ykk7e13QpCDarGi38HlmzdMJNwghE3Kl1hqzLtQp1J78PbSkMw09iJelsZUffn4AFV +Tq4udBSiO14z+kGlKlY82sdDQt0hz5BYfVuf4/ZiJzUAZNnFxEMKmD9wHITf8ikMFClIp PgSxAkLtUsnraoXgX3j1T/u3RXduuNKf0Y9k+mXgtW7AWdm/gJbYRxjBqYmFww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1782259421; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O4lH9eASnZpQ5ugOGXzViAFk8+XHWHjlrIFyV4PU7Vc=; b=llacy+EQ0slPT+wRBwo/69AMMlOhlB/qFgfwRpCdtIQL30hteDuTop86cFYCQRKhCbHN0Y 34CTP+91PHu1PZmEqNyOzVtiku4SXwK5cOrezmcbWNkneizKXA5slefvZmPlnSSGohaKf4 ZB5/OM2/b4dnhwF3iVpG0DkMlimfVsNNxm/vKRWL4X+xN1W1vVOMM34FQa3kschGvWFE1g 5zXsOndJqz6KXA+Aj/baynaijhOwRy0BB7mS99L2vE0frJ7Qx0Ta5ACkbe1E9ySgiryC0C 41YWrw4LubgEmirk3TLjXBf2etCoVwLpZk05EA2soFMMZ8zB1LViC6GDIz1MlA== Received: from ltc.des.dev (unknown [92.183.55.143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4glMbd3zqGz1J9d; Wed, 24 Jun 2026 00:03:41 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id 257D750024; Wed, 24 Jun 2026 02:03:40 +0200 (CEST) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Alan Somers Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org, Jitendra Bhati Subject: Re: git: e03ed9daeb49 - main - fts: refactor to use fd-relative operations internally In-Reply-To: <6a3a9e2c.1d985.79db71af@gitrepo.freebsd.org> (Alan Somers's message of "Tue, 23 Jun 2026 14:54:36 +0000") References: <6a3a9e2c.1d985.79db71af@gitrepo.freebsd.org> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Wed, 24 Jun 2026 02:03:40 +0200 Message-ID: <864iispzxf.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Alan Somers writes: > commit e03ed9daeb49fffa1d16b8d00240c65e92650d01 > Author: Jitendra Bhati > AuthorDate: 2026-06-12 17:07:55 +0000 > Commit: Alan Somers > CommitDate: 2026-06-23 14:53:56 +0000 > > fts: refactor to use fd-relative operations internally >=20=20=20=20=20 > Replace all _open() calls with _openat() in __fts_open(), fts_read(), > and fts_children(). >=20=20=20=20=20 > Add fts_dirfd to FTSENT. Callers can use > openat(ent->fts_dirfd, ent->fts_name, ...) to access files > safely without relying on fts_accpath, which enables: >=20=20=20=20=20 > 1. Capsicum capability mode where path-based operations fail > 2. Security-sensitive programs that avoid TOCTOU races >=20=20=20=20=20 > Replace statfs(ent->fts_path) with _fstatfs(ent->fts_dirfd) in > fts_ufslinks() when fts_dirfd is valid, falling back to statfs() for > root-level entries where fts_dirfd is -1 >=20=20=20=20=20 > This is a preparatory change for fts_openat() which will allow > callers to provide a pre-opened directory fd, enabling fts(3) > traversal inside Capsicum capability mode. >=20=20=20=20=20 > Sponsored by: Google LLC (GSoC 2026) > Reviewed by: asomers, jillest > MFC after: 2 weeks > Pull Request: https://github.com/freebsd/freebsd-src/pull/2278 This needs to be reverted. It changes struct _ftsent which is part of the libc ABI. You will have to fork FTS (again) and have one version with fts_dirfd and fts_openat() and one without. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org