From owner-svn-src-all@freebsd.org Sat Oct 31 11:46:53 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 42D4E44936F; Sat, 31 Oct 2020 11:46:53 +0000 (UTC) (envelope-from xtouqh@hotmail.com) Received: from EUR04-HE1-obe.outbound.protection.outlook.com (mail-oln040092073029.outbound.protection.outlook.com [40.92.73.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "GlobalSign Organization Validation CA - SHA256 - G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CNcph00W7z4Mqs; Sat, 31 Oct 2020 11:46:51 +0000 (UTC) (envelope-from xtouqh@hotmail.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Yp8OInPZg5UKjihWIxZGGCHDYUe+3gkLzUSs6YIuqO/x5ccn1MnfQ8VvMDv4LT8myun/eRQlAmYFCXIyDKJyfmY5uTWIc5ToRLeGe2OZP5Z0UuOdaVQ109wprYOk8LEoJhyhBMd/ADVgrDJJs1WS8gv6MZfo3EaneN7ajaxdhpQSoTHQ99mtgztfZxlJb+9rLGoprcG4otUwGgXyx6Ynd/E9rD7A276SZwX8fPnJMwDCXmDx4Xld7qA4XqzlxPRaqb64dvfX1YLHiLzol3GZM8v9ct9OecITiwV/ncjFRbdY+mMcw5jI/jsA2261tJcDSuDv8FCwWHZVZfP0F1gTJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sp1UR98Qg5ZUmJpOIUR6Nn9mTdsfmdOVuK4nxQp65+k=; b=XsMjmw+9et5boMPq7bccLD6e/VYhN8VZVSZjtTxq7Djy+segZHnICu96Y8mVwNgw4ioVSHf6abHJP7Pdd+geDOOF2iYFqCx+RIYX7jS97rJvKJynF4c389rhqYN41Sx1CmyBOcB4TCAkkbemaLdVS5BMphALigqUDCmSQSKr4C19xVZUv4UiHaKfxpDcIGwL57k+pDSzsN6OTWpld22eHnhkCzgw0XaMlsLngyW8u2zBE20mAR139UaxPgMsiyUCQOoyzAdICqBoejgY8xxPZKdPPCxOTSuhaHPD+e0RkcRFmw9XW/LsLChxw0Q1upU9Qa/I9TOV6SgecmRvyIThng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sp1UR98Qg5ZUmJpOIUR6Nn9mTdsfmdOVuK4nxQp65+k=; b=N1JLssYsCV0esp2rAUsVtA/oAR2XMwD58Ss2Cj4my+hSfaUcXStqLZ2yNhJ7e0KBSu5b5E7BsQez9hqqCWIx8q9bEMIwTs/PB7G4PsdrBORdnn7vJy94Mos97USA/EW1tvITu+NaER7ljm/2yIWPypRPjgTqgV+ZJLxcOgZvjOGDUxIAVOqxoMGw8SYSIMDJBGnepciCnUXVETOwB1cKTpxbVTzzM8MzoB0ibX61aFBXXtHGKl163Ny9580lTQf8OLvAZSHp68N9Chj8frNCk5rnSiGvwPu8dnpXLhURn790ZPzEFHqfx2MUIG55l4G16q0wa3vwBmWzNu7dVkoiRQ== Received: from HE1EUR04FT052.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0d::52) by HE1EUR04HT019.eop-eur04.prod.protection.outlook.com (2a01:111:e400:7e0d::66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15; Sat, 31 Oct 2020 11:46:49 +0000 Received: from AM0PR06MB3986.eurprd06.prod.outlook.com (2a01:111:e400:7e0d::42) by HE1EUR04FT052.mail.protection.outlook.com (2a01:111:e400:7e0d::297) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3520.15 via Frontend Transport; Sat, 31 Oct 2020 11:46:49 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:1021A006DE72009D57D1570AB1A2FF10572DE8FB8C5C264D8F0950D462045059; UpperCasedChecksum:EC077A9CFD4601522ABD7AD1D090E17C34B05F24B4966D29D14FC81BCD8970AA; SizeAsReceived:8673; Count:47 Received: from AM0PR06MB3986.eurprd06.prod.outlook.com ([fe80::759a:af46:6f2:8fb8]) by AM0PR06MB3986.eurprd06.prod.outlook.com ([fe80::759a:af46:6f2:8fb8%7]) with mapi id 15.20.3499.029; Sat, 31 Oct 2020 11:46:49 +0000 Subject: Re: svn commit: r367196 - head/lib/libc/gen To: =?UTF-8?Q?Stefan_E=c3=9fer?= , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <202010311144.09VBiBbh063210@repo.freebsd.org> From: xtouqh@hotmail.com Message-ID: Date: Sat, 31 Oct 2020 14:46:47 +0300 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 In-Reply-To: <202010311144.09VBiBbh063210@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-TMN: [yZts5nuL2X4EyvfFBie9THpD5qX7ROiv] X-ClientProxiedBy: AM0PR04CA0047.eurprd04.prod.outlook.com (2603:10a6:208:1::24) To AM0PR06MB3986.eurprd06.prod.outlook.com (2603:10a6:208:b6::28) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.1.6] (91.240.124.157) by AM0PR04CA0047.eurprd04.prod.outlook.com (2603:10a6:208:1::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Sat, 31 Oct 2020 11:46:48 +0000 X-MS-PublicTrafficType: Email X-IncomingHeaderCount: 47 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-Correlation-Id: ac9d2173-cdbf-426d-446f-08d87d92a67f X-MS-TrafficTypeDiagnostic: HE1EUR04HT019: X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: b50odqrIxzzvfcJCnTrE/i+3bHRCZNjyoOPpE9TeJVaNkEnvMTFDfDBR6IkK3ETCqSbGiTnePraeDS8/a3MP6ZiAzRTAtnvCQwMkewIaeIqMyHlSLvB3kkzlDOmEiT9P+AW7yode2oMePa0UMwOJBVlOiYifoMjyNaHoP6cEzf34NQGKUoKq8c1gFaOClVChO4Tm+XSKuLlOMRDOfMldZwWmFPluXrWM+hFbGL9ekj2HWDMM2dYc/o2+VwPwGaK6 X-MS-Exchange-AntiSpam-MessageData: ZLvhaMGr4eyFFE/mH6/qOuQcQu3fzE6p7iybJCNt1GXOv5aQzPoC7oRu37NfvXOQL8auBlGetHxbh4cZB1ZpogAaMyqa2XGoqyuN0zPDpdRvTqiBuP3hGbfQHusa6tpgz/oqvEHL9kUomMX4rxwyGQ== X-OriginatorOrg: hotmail.com X-MS-Exchange-CrossTenant-Network-Message-Id: ac9d2173-cdbf-426d-446f-08d87d92a67f X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Oct 2020 11:46:48.9368 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-AuthSource: HE1EUR04FT052.eop-eur04.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: Internet X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: HE1EUR04HT019 X-Rspamd-Queue-Id: 4CNcph00W7z4Mqs X-Spamd-Bar: -- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=hotmail.com header.s=selector1 header.b=N1JLssYs; dmarc=pass (policy=none) header.from=hotmail.com; spf=pass (mx1.freebsd.org: domain of xtouqh@hotmail.com designates 40.92.73.29 as permitted sender) smtp.mailfrom=xtouqh@hotmail.com X-Spamd-Result: default: False [-2.30 / 15.00]; TO_DN_SOME(0.00)[]; FREEMAIL_FROM(0.00)[hotmail.com]; R_SPF_ALLOW(-0.20)[+ip4:40.92.0.0/15]; DKIM_TRACE(0.00)[hotmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[hotmail.com,none]; NEURAL_HAM_SHORT(-0.82)[-0.821]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[hotmail.com]; ASN(0.00)[asn:8075, ipnet:40.80.0.0/12, country:US]; FORGED_MUA_THUNDERBIRD_MSGID_UNKNOWN(2.50)[]; DWL_DNSWL_NONE(0.00)[hotmail.com:dkim]; RCVD_TLS_LAST(0.00)[]; NEURAL_HAM_MEDIUM(-1.01)[-1.011]; R_DKIM_ALLOW(-0.20)[hotmail.com:s=selector1]; RCVD_COUNT_FIVE(0.00)[5]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-0.97)[-0.966]; MIME_GOOD(-0.10)[text/plain]; ARC_ALLOW(-1.00)[microsoft.com:s=arcselector9901:i=1]; FROM_NO_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[40.92.73.29:from]; RWL_MAILSPIKE_POSSIBLE(0.00)[40.92.73.29:from]; MAILMAN_DEST(0.00)[svn-src-head,svn-src-all] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 31 Oct 2020 11:46:53 -0000 Stefan Eßer wrote: > Author: se > Date: Sat Oct 31 11:44:10 2020 > New Revision: 367196 > URL: https://svnweb.freebsd.org/changeset/base/367196 > > Log: > Fix style, no functional change > > Submitted by: kib > MFC after: 3 days > > Modified: > head/lib/libc/gen/sysctl.c > > Modified: head/lib/libc/gen/sysctl.c > ============================================================================== > --- head/lib/libc/gen/sysctl.c Sat Oct 31 03:36:31 2020 (r367195) > +++ head/lib/libc/gen/sysctl.c Sat Oct 31 11:44:10 2020 (r367196) > @@ -79,23 +79,23 @@ sysctl(const int *name, u_int namelen, void *oldp, siz > > switch (name[1]) { > case USER_CS_PATH: > - if (oldp && orig_oldlen < sizeof(_PATH_STDPATH)) { > + if (oldp == NULL && orig_oldlen < sizeof(_PATH_STDPATH)) { These checks are not identical, should not the new one be != NULL? > errno = ENOMEM; > - return -1; > + return (-1); > } > *oldlenp = sizeof(_PATH_STDPATH); > if (oldp != NULL) > memmove(oldp, _PATH_STDPATH, sizeof(_PATH_STDPATH)); > return (0); > case USER_LOCALBASE: > - if (oldp && orig_oldlen < sizeof(_PATH_LOCALBASE)) { > + if (oldp == NULL && orig_oldlen < sizeof(_PATH_LOCALBASE)) { Same here. > errno = ENOMEM; > - return -1; > + return (-1); > } > *oldlenp = sizeof(_PATH_LOCALBASE); > if (oldp != NULL) > memmove(oldp, _PATH_LOCALBASE, sizeof(_PATH_LOCALBASE)); > - return(0); > + return (0); > } > > if (oldp && *oldlenp < sizeof(int)) {