Date: Fri, 20 Mar 2009 15:38:44 -0400 From: John Baldwin <jhb@freebsd.org> To: freebsd-arch@freebsd.org Cc: Rick Macklem <rmacklem@uoguelph.ca>, Alfred Perlstein <alfred@freebsd.org>, Zachary Loafman <zachary.loafman@isilon.com> Subject: Re: NFS version 4.0 for FreeBSD-CURRENT Message-ID: <200903201538.45268.jhb@freebsd.org> In-Reply-To: <Pine.GSO.4.63.0903201149590.23530@muncher.cs.uoguelph.ca> References: <Pine.GSO.4.63.0903151520590.16993@muncher.cs.uoguelph.ca> <20090319164251.GA13081@zloafman.west.isilon.com> <Pine.GSO.4.63.0903201149590.23530@muncher.cs.uoguelph.ca>
next in thread | previous in thread | raw e-mail | index | archive | help
On Friday 20 March 2009 12:03:57 pm Rick Macklem wrote: > > On Thu, 19 Mar 2009, Zachary Loafman wrote: > > [good stuff snipped] > > > > I don't know if that affects the timing on this being merged to CURRENT > > or not. It might be nice if we had an opportunity to review some things > > prior to APIs/VOPs being set in stone, but it would also be nice to get > > wider exposure for Rick's code. > > > Other than the va_filerev/i_modrev issue already mentioned (btw, I grep'd > /usr/src and nothing uses va_filerev outside the kernel, it seems), I > realized there is another API/VOP issue (kinda in the trivial category, > but I should mention it). FreeBSD-CURRENT is out of bits for mnt_flag (the > last spare one is used by Edward's ACL code) and it would be nice to add a > couple of MNT_EXxxx flags for things like enabling/disabling delegations. > > Two obvious possible solutions: > 1 - bump mnt_flag up to 64 bits > 2 - create a separate mnt_exflag field FreeBSD in general is moving away from new flags in mnt_flags I believe. At least if you purely need NFS-specific flags you can just add new string options via nmount(2) and set appropriate settings in private flags field in your NFS-specific mount data. -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903201538.45268.jhb>