From owner-freebsd-arch@FreeBSD.ORG Fri Mar 20 19:46:07 2009 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 054CA1065676; Fri, 20 Mar 2009 19:46:07 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id C6A9A8FC17; Fri, 20 Mar 2009 19:46:06 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (pool-98-109-39-197.nwrknj.fios.verizon.net [98.109.39.197]) by cyrus.watson.org (Postfix) with ESMTPSA id 63BE546B6C; Fri, 20 Mar 2009 15:46:06 -0400 (EDT) Received: from localhost (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id n2KJk0Xp028411; Fri, 20 Mar 2009 15:46:00 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: freebsd-arch@freebsd.org Date: Fri, 20 Mar 2009 15:38:44 -0400 User-Agent: KMail/1.9.7 References: <20090319164251.GA13081@zloafman.west.isilon.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200903201538.45268.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Fri, 20 Mar 2009 15:46:00 -0400 (EDT) X-Virus-Scanned: ClamAV 0.94.2/9145/Fri Mar 20 10:59:16 2009 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: Rick Macklem , Alfred Perlstein , Zachary Loafman Subject: Re: NFS version 4.0 for FreeBSD-CURRENT X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Mar 2009 19:46:07 -0000 On Friday 20 March 2009 12:03:57 pm Rick Macklem wrote: > > On Thu, 19 Mar 2009, Zachary Loafman wrote: > > [good stuff snipped] > > > > I don't know if that affects the timing on this being merged to CURRENT > > or not. It might be nice if we had an opportunity to review some things > > prior to APIs/VOPs being set in stone, but it would also be nice to get > > wider exposure for Rick's code. > > > Other than the va_filerev/i_modrev issue already mentioned (btw, I grep'd > /usr/src and nothing uses va_filerev outside the kernel, it seems), I > realized there is another API/VOP issue (kinda in the trivial category, > but I should mention it). FreeBSD-CURRENT is out of bits for mnt_flag (the > last spare one is used by Edward's ACL code) and it would be nice to add a > couple of MNT_EXxxx flags for things like enabling/disabling delegations. > > Two obvious possible solutions: > 1 - bump mnt_flag up to 64 bits > 2 - create a separate mnt_exflag field FreeBSD in general is moving away from new flags in mnt_flags I believe. At least if you purely need NFS-specific flags you can just add new string options via nmount(2) and set appropriate settings in private flags field in your NFS-specific mount data. -- John Baldwin