Date: Sat, 12 Oct 2013 15:10:25 +0000 From: "Teske, Devin" <Devin.Teske@fisglobal.com> To: Nathan Whitehorn <nwhitehorn@freebsd.org> Cc: "svn-src-head@freebsd.org" <svn-src-head@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "src-committers@freebsd.org" <src-committers@freebsd.org>, "Teske, Devin" <Devin.Teske@fisglobal.com> Subject: Re: svn commit: r256343 - in head/usr.sbin/bsdinstall: . scripts Message-ID: <13CA24D6AB415D428143D44749F57D720FC5B7DF@LTCFISWMSGMB21.FNFIS.com> In-Reply-To: <13CA24D6AB415D428143D44749F57D720FC5B547@LTCFISWMSGMB21.FNFIS.com> References: <201310112041.r9BKfZeT002056@svn.freebsd.org> <5258F9B3.7030101@freebsd.org> <13CA24D6AB415D428143D44749F57D720FC5B547@LTCFISWMSGMB21.FNFIS.com>
next in thread | previous in thread | raw e-mail | index | archive | help
[snip] >=20 >> Installer regressions are very easy to introduce and very problematic >=20 > Don't I know (looks at *you*) >=20 >=20 >=20 >> when created. Real review for installer changes is thus especially >> important this late in the release cycle. >=20 > Using camcontrol is not the end of the world -- even if the code is read-= only to you... > you should be able to ... "read it?" >=20 >=20 >> Do you have any plans to fix >> these issues in the very near future? >=20 > Yes. Which has been discussed at-length, you didn't need to put a sandbag= on my back > (publicly no less; thanks for that). I apologize... I should have gone on to explain that... The use of camcontrol is protected by a conditional block making use of the= f_have() function which means if you rip out camcontrol completely (in any way resul= ting in the binary being absent) then the value-add potentially provided by camcontrol = is silently skipped as the utility is not available. So let's say you don't have camcontrol(8) in the media, *or* say that you h= ave a kernel lacking CAM knobs... No problem. I could have completely omitted the camcontrol value-add, ... what we had a= lready was sufficient enough to describe disks. It was only upon Allan's testing that he noticed that the labels could be..= . better ;D So I went scrounging for something that could supersede the description of = a `da0' that would satisfy Allan, and I found it in camcontrol -- his testing confi= rmed. I don't know if he was using a kernel enhanced with CAM through custom conf= iguration or if he was using everything stock... and I could ask him... but it appear= ed to be working *and* I protected it with f_have() so in the event that it doesn't work for every= one... no biggie... the descriptions will be as they were before the value-add (still there, bu= t not as accurate as they could be... enter jmg@ and a parsing of geom later). I think of all people, you should understand that if something doesn't intr= oduce a blocker, but lacks a particular value-add (in this case, geom parsing), then it shou= ld be OK to proceed (I'm not harping on you, but I'm specifically calling out that bsdi= nstall did not implement everything needed by VICOR "out of the box"; so we're still on 8.= x because we rely on much functionality in sysinstall that bsdinstall doesn't impleme= nt). So I'm a bit shocked to see you coming down so hard on this commit. It will be addressed, but I also had to first address jilles@ Integer Overf= low statement (I _on purpose_ committed the code we had because it had to go in, and then= *very* quickly followed it up with a fix to the integer overflow detection). You'r= e next in-line, but the geom parsing may not make it in until BETA2 (I honestly need a brea= k from that last round of commits... it took me a solid week of sleepless nights -- the= wife and I would like some time together, please). In light of that last paragraph... we're all Human... and what we do is vol= unteer. So I can't harp on you legitimately for any short-comings. But I do request a little s= lack considering I didn't break anything and this is *not* that serious in the grand scheme = of things. There are no regressions that I can see which you speak of. --=20 Devin _____________ The information contained in this message is proprietary and/or confidentia= l. If you are not the intended recipient, please: (i) delete the message an= d all copies; (ii) do not disclose, distribute or use the message in any ma= nner; and (iii) notify the sender immediately. In addition, please be aware= that any message addressed to our domain is subject to archiving and revie= w by persons other than the intended recipient. Thank you.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13CA24D6AB415D428143D44749F57D720FC5B7DF>