Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 4 Jul 2025 14:07:16 GMT
From:      Ahmad Khalifa <vexeduxr@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: c2d8cca77152 - main - gpio: remove redundant calls to bus_attach_children
Message-ID:  <202507041407.564E7GM5080626@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by vexeduxr:

URL: https://cgit.FreeBSD.org/src/commit/?id=c2d8cca77152ebf72f488490163585be7e34eb0f

commit c2d8cca77152ebf72f488490163585be7e34eb0f
Author:     Ahmad Khalifa <vexeduxr@FreeBSD.org>
AuthorDate: 2025-07-04 13:51:11 +0000
Commit:     Ahmad Khalifa <vexeduxr@FreeBSD.org>
CommitDate: 2025-07-04 13:55:05 +0000

    gpio: remove redundant calls to bus_attach_children
    
    gpiobus_attach_bus already calls it.
    
    Reviewed by:    mmel, imp, andrew
    Approved by:    imp (mentor)
    MFC after:      3 days
    Differential Revision:  https://reviews.freebsd.org/D51108
---
 sys/arm/mv/mvebu_gpio.c     | 1 -
 sys/arm/nvidia/tegra_gpio.c | 1 -
 2 files changed, 2 deletions(-)

diff --git a/sys/arm/mv/mvebu_gpio.c b/sys/arm/mv/mvebu_gpio.c
index 681cf20f7f9f..7acdfff539dc 100644
--- a/sys/arm/mv/mvebu_gpio.c
+++ b/sys/arm/mv/mvebu_gpio.c
@@ -810,7 +810,6 @@ mvebu_gpio_attach(device_t dev)
 		return (ENXIO);
 	}
 
-	bus_attach_children(dev);
 	return (0);
 }
 
diff --git a/sys/arm/nvidia/tegra_gpio.c b/sys/arm/nvidia/tegra_gpio.c
index 16e1ef94d6a9..e37fd69a121e 100644
--- a/sys/arm/nvidia/tegra_gpio.c
+++ b/sys/arm/nvidia/tegra_gpio.c
@@ -824,7 +824,6 @@ tegra_gpio_attach(device_t dev)
 		return (ENXIO);
 	}
 
-	bus_attach_children(dev);
 	return (0);
 }
 



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202507041407.564E7GM5080626>