From owner-svn-src-head@FreeBSD.ORG Sat Dec 21 16:31:57 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 3C240C1F; Sat, 21 Dec 2013 16:31:57 +0000 (UTC) Received: from smtpauth3.wiscmail.wisc.edu (wmauth3.doit.wisc.edu [144.92.197.226]) (using TLSv1 with cipher RC4-MD5 (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 03B5910C6; Sat, 21 Dec 2013 16:31:56 +0000 (UTC) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII Received: from avs-daemon.smtpauth3.wiscmail.wisc.edu by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) id <0MY500F00YNR1M00@smtpauth3.wiscmail.wisc.edu>; Sat, 21 Dec 2013 10:31:55 -0600 (CST) X-Spam-PmxInfo: Server=avs-3, Version=6.0.3.2322014, Antispam-Engine: 2.7.2.2107409, Antispam-Data: 2013.12.21.162415, SenderIP=0.0.0.0 X-Spam-Report: AuthenticatedSender=yes, SenderIP=0.0.0.0 Received: from wanderer.tachypleus.net (172-12-164-50.lightspeed.wlfrct.sbcglobal.net [172.12.164.50]) by smtpauth3.wiscmail.wisc.edu (Oracle Communications Messaging Server 7u4-27.01(7.0.4.27.0) 64bit (built Aug 30 2012)) with ESMTPSA id <0MY600K9W0L59000@smtpauth3.wiscmail.wisc.edu>; Sat, 21 Dec 2013 10:31:54 -0600 (CST) Message-id: <52B5C279.4020103@freebsd.org> Date: Sat, 21 Dec 2013 10:31:53 -0600 From: Nathan Whitehorn User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.0 To: Devin Teske Subject: Re: svn commit: r259468 - head/usr.sbin/bsdinstall/scripts References: <201312161550.rBGFox0N001344@svn.freebsd.org> <52AF2502.1060503@freebsd.org> <52B5AA94.3060009@freebsd.org> <52B5BDD1.3000106@freebsd.org> <37E2A444-38C0-4E8C-A2E1-5FA23B9B0FFF@fisglobal.com> In-reply-to: <37E2A444-38C0-4E8C-A2E1-5FA23B9B0FFF@fisglobal.com> X-Enigmail-Version: 1.5.2 Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" , "Teske, Devin" X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Dec 2013 16:31:57 -0000 On 12/21/13 10:25, Teske, Devin wrote: > On Dec 21, 2013, at 8:12 AM, Nathan Whitehorn wrote: > >> Looks great, thanks -- although you don't need the f_quietly, which >> isn't defined there. >> >> The issue is that this patch very specific to running the installer on a >> video console. There are many circumstances in which it is not, in which >> case this will fail (e.g. a serial console). The other thing is that the >> installer should not reconfigure the host system unless it has been >> explicitly asked to. It isn't always run from the install media. If you >> think the default bindings for these keys don't make sense, then that >> should ultimately be fixed in the console driver as well. > My inspiration for this change came from a tweet in which we were > (unjustly or not; doesn't matter) slammed for not having addressed > this issue since it (as the person claims) first appeared in 6.x. > > Having felt the persons pain (and verified that, indeed, we continue > to be plagued in 10) I decided to do start researching the problem > in-depth. > > The links I posted in the commit message give an excellent view of > the issue and in-fact doesn't even mention using kbdcontrol. Instead > it is suggested that we create an alternate keymap that ignores the > command keys. > > That sounds like one approach (and wins points because it is opt- > in) but it doesn't solve the problem for me or anyone else running > the installer. > > Perhaps if we had this alternate keymap in the base which does the > desired thing (ignore the command keys), then we could just say that > the user ought to select said keymap at the onset of the installation > process. > > But I'm not sure *I* like that approach because then it means that for > my own testing, I have to select an alternate keymap everytime I run > the installer in VMware. > > Rather, it seems to me that the installation process, if it ignored the > command key on every non-serial platform... this would be fine. > Afterall, once they get the system installed, they'll have the desired > keymap set and they can forget. I'd prefer opt-out -- having the default be the option that is least surprising is a good idea. In any case, moving it to rc.local solves all the immediate problem. -Nathan