From owner-svn-src-head@FreeBSD.ORG Fri Jun 19 14:39:25 2015 Return-Path: Delivered-To: svn-src-head@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id E8A0F79B; Fri, 19 Jun 2015 14:39:25 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id A30CED82; Fri, 19 Jun 2015 14:39:25 +0000 (UTC) (envelope-from hps@selasky.org) Received: from laptop015.home.selasky.org (cm-176.74.213.204.customer.telag.net [176.74.213.204]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 00EC01FE023; Fri, 19 Jun 2015 16:39:22 +0200 (CEST) Message-ID: <558429D0.1000808@selasky.org> Date: Fri, 19 Jun 2015 16:40:16 +0200 From: Hans Petter Selasky User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: araujo@FreeBSD.org CC: David Chisnall , "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" Subject: Re: svn commit: r268137 - head/sys/sys References: <201407020845.s628jRG5031824@svn.freebsd.org> <5BE3492F-86A0-4CE3-A27C-8DB5EB662C64@FreeBSD.org> <5583F2C9.1030409@selasky.org> <1EB851FC-CA78-4A7B-BE5D-4F050C61A14C@FreeBSD.org> <558403C4.4040500@selasky.org> <55841BF3.8010205@selasky.org> <74BE6DD6-1C0F-4E59-8913-CFCE7DD744CB@FreeBSD.org> <55842746.5040105@selasky.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Jun 2015 14:39:26 -0000 On 06/19/15 16:32, Marcelo Araujo wrote: > 2015-06-19 22:29 GMT+08:00 Hans Petter Selasky : > >> On 06/19/15 16:22, David Chisnall wrote: >> >>>> Right - can you explain why it is ending up in your ObjC code? >>>> >>> Because it’s in cdefs.h, which is included by*every single userspace C >>> header*. cdefs.h must work with all C-family languages. >>> >>> David >>> >>> >> Hi David, >> >> My buildworld and buildkernel has just successfully completed. I'll rename >> the define and its clients in -current shortly. Will be MFC'ed to 10-stable >> in 1 weeks time, so that any errors out there in ports will show up. Is >> this fine by you? >> >> Instead of __weak it will be __weak_symbol . Googled a bit about >> __weak_symbol and it seems to be free. >> >> > Hi, > > Maybe would be a good idea run an 'exp run' with this patch? Just to double > check if any port will break, although after you rename, I don't believe it > will conflict anymore, however an 'exp run' would show you it. > > > Best Regards, > Hi, Here is a PR and a patch. Let's move the discussion over there if any further issues: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=200972 --HPS