Date: Mon, 24 Nov 2014 19:45:01 +0000 From: Brooks Davis <brooks@freebsd.org> To: Chris Rees <crees@physics.org> Cc: Chris Rees <crees@FreeBSD.org>, svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org, Adam Weinberger <adamw@adamw.org> Subject: Re: svn commit: r373100 - in head: . Mk databases/glom databases/libzdb databases/opendbx databases/pglesslog databases/qt4-pgsql-plugin databases/qt5-sqldrivers-pgsql databases/rubygem-do_postgres dat... Message-ID: <20141124194501.GD37386@spindle.one-eyed-alien.net> In-Reply-To: <547103CD.2020309@physics.org> References: <201411222040.sAMKe9tk086292@svn.freebsd.org> <48EBC1CA-CB07-47E0-88A3-94B1ED7B31A0@adamw.org> <547103CD.2020309@physics.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--cWoXeonUoKmBZSoM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sat, Nov 22, 2014 at 09:44:45PM +0000, Chris Rees wrote: > On 22/11/2014 21:31, Adam Weinberger wrote: > > On 22 Nov, 2014, at 13:40, Chris Rees <crees@FreeBSD.org> wrote: > >> Author: crees > >> Date: Sat Nov 22 20:40:08 2014 > >> New Revision: 373100 > >> URL: https://svnweb.freebsd.org/changeset/ports/373100 > >> QAT: https://qat.redports.org/buildarchive/r373100/ > >> > >> Log: > >> Finally retire USE_PGSQL > >> > >> + USE_PGSQL=3Dserver becomes USES=3Dpgsql and WANT_PGSQL=3Dserver > > USES=3Dperl5 has USE_PERL5, USES=3Dpython has USE_PYTHON, USES=3Dopenal= has USE_OPENAL, USES=3Dfam has USE_FAM. > > > > Why is pgsql WANT_ instead of USE_? >=20 > Hm. A couple of reasons really; USE_PGSQL was used before by=20 > bsd.database.mk, and with the two coexisting perhaps sharing the=20 > variable was not desired; I remember back in December last year when=20 > writing this that people weren't keen on separate variables at all,=20 > preferring to use arguments to USES. During that discussion, no-one=20 > mentioned that WANT_PGSQL wasn't desirable (perhaps it wasn't even=20 > discussed). >=20 > I could rename it to USE_PGSQL now the code is removed from=20 > bsd.database.mk I suppose... but is it necessary? I don't personally=20 > think it's a great idea to reuse variables that used to mean something=20 > else... >=20 Please don't use WANT_* or NEED_* in ports. We're planning to place current USE_* variables in base to use them to avoid conflicts with USE_* variables. It's unlikely this one will be a problem so I'm OK with this one staying around for a transition period, but let's not add more. -- Brooks --cWoXeonUoKmBZSoM Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlRzir0ACgkQXY6L6fI4GtR9ZQCfaszMRmOj5DLDDNCRssNyMxyB ICwAoJwPbYufCii1rStB/8loRvoBsWBy =uEqp -----END PGP SIGNATURE----- --cWoXeonUoKmBZSoM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20141124194501.GD37386>