From owner-svn-src-head@FreeBSD.ORG Fri Feb 13 23:56:35 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 6085BE98 for ; Fri, 13 Feb 2015 23:56:35 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 24F44E0B for ; Fri, 13 Feb 2015 23:56:35 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t1DNuZah052982 for ; Fri, 13 Feb 2015 23:56:35 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t1DNuYKJ052978 for svn-src-head@freebsd.org; Fri, 13 Feb 2015 23:56:34 GMT (envelope-from bdrewery) Received: (qmail 49879 invoked from network); 13 Feb 2015 17:56:33 -0600 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 13 Feb 2015 17:56:33 -0600 Message-ID: <54DE8F32.2090500@FreeBSD.org> Date: Fri, 13 Feb 2015 17:56:34 -0600 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: phabric-admin@FreeBSD.org Subject: Phabricator + 'Reviewed by' [was Re: svn commit: r278472 - in head/sys: netinet netinet6] References: <201502091928.t19JSC5P066293@svn.freebsd.org> <38B8D2D0-862A-4DF5-9479-8EC234CF830B@FreeBSD.org> In-Reply-To: <38B8D2D0-862A-4DF5-9479-8EC234CF830B@FreeBSD.org> OpenPGP: id=6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="CHPCqFm4vFQ6uQJe43XLi1G1hE8sR8FNn" Cc: svn-src-head@freebsd.org, Randall Stewart , svn-src-all@freebsd.org, "Bjoern A. Zeeb" , src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Feb 2015 23:56:35 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CHPCqFm4vFQ6uQJe43XLi1G1hE8sR8FNn Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 2/9/2015 3:45 PM, Bjoern A. Zeeb wrote: >> Commented upon by hiren and sbruno >> See Phabricator D1777 for more details. >> >> Commented upon by hiren and sbruno >> Reviewed by: adrian, jhb and bz > I have not reviewed this; as a matter of fact you are aware that I sti= ll wanted to do that. >=20 Something about Phabricator is not jiving with our commit terminology. This has happened before as well with other commits. I'm sure everyone is good-intentioned as well. There's not 1 person on D1777 who has 'accepted' it. That is what warrants a 'Reviewed by' to me. It's clear to me, but seems unclear to others. I really think the reviewer list needs to be split up. Rather than using icons, use separate lists. Reviewers requested: accepted: commented: changes requested:. --=20 Regards, Bryan Drewery --CHPCqFm4vFQ6uQJe43XLi1G1hE8sR8FNn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJU3o83AAoJEDXXcbtuRpfPbO4IAK82RIVhFWKAH8z5hdPgzTlL X//0xTRpXCrTrUH0v/ZYsEyrZ7AtquybHaZ+QPYoL/vFwnst24FvXkOe2DReDMD0 ej0h7bmYHzhPP9i5sKNLr/xRZ/ngj09pgDL0UHhJJ5Ax60nDvtpIvSQdkAl6gGad 2SdXhYVy596406WfjWA95gf1a2Mc6npoQ+lCO8BobOKnwsu140xIYIGP4bAtIpKb kgW9YKo491n4UzWg7FgqpH1im13DNTdzl9CgJa+UxkfW1CF8sO0ER/sjmH3B3KCn zSsaydw85xOdFhygRuNcHfW3NWhCaiYVH27i6KZ2Dx9KuFCMxrJmelw/Z8x1vV0= =7Ofk -----END PGP SIGNATURE----- --CHPCqFm4vFQ6uQJe43XLi1G1hE8sR8FNn--