From owner-freebsd-multimedia@freebsd.org Sun Mar 25 20:54:53 2018 Return-Path: Delivered-To: freebsd-multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 6709EF6C693 for ; Sun, 25 Mar 2018 20:54:53 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id E1B5A77EBE for ; Sun, 25 Mar 2018 20:54:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.ysv.freebsd.org (Postfix) id A2205F6C687; Sun, 25 Mar 2018 20:54:52 +0000 (UTC) Delivered-To: multimedia@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8F601F6C686 for ; Sun, 25 Mar 2018 20:54:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.ysv.freebsd.org (mxrelay.ysv.freebsd.org [IPv6:2001:1900:2254:206a::19:3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "mxrelay.ysv.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 2887B77EB8 for ; Sun, 25 Mar 2018 20:54:52 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.ysv.freebsd.org (Postfix) with ESMTPS id 41D3914AE9 for ; Sun, 25 Mar 2018 20:54:51 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id w2PKspxJ045498 for ; Sun, 25 Mar 2018 20:54:51 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id w2PKspwq045496 for multimedia@FreeBSD.org; Sun, 25 Mar 2018 20:54:51 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" From: bugzilla-noreply@freebsd.org To: multimedia@FreeBSD.org Subject: maintainer-feedback requested: [Bug 226926] [PATCH] Tools/scripts/bump-revision.sh lack a safety belt Date: Sun, 25 Mar 2018 20:54:50 +0000 X-Bugzilla-Type: request X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: multimedia@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? Message-ID: In-Reply-To: References: X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 25 Mar 2018 20:54:53 -0000 Bugzilla Automation has asked multimedia@FreeBSD.org= for maintainer-feedback: Bug 226926: [PATCH] Tools/scripts/bump-revision.sh lack a safety belt https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D226926 --- Description --- Before my commit in revision r464215 (cf. bug #226533)=20 Tools/scripts/bump-revision.sh would wreak havoc on the multimedia/avidemux* ports. This can hardly be blamed on bump-revision.sh, but a safety belt for this important script would be a good idea. My attached patch tries to accomplish that, but using `make -V PORTREVISION` before and after the bumping and raising an error if the latter value is lower or equal to the former. How to reproduce: % cd $PORTSDIR % svn up -r 464036 multimedia/ % Tools/scripts/bump-revision.sh multimedia/avidemux* With my patch this prints: INFO: multimedia/avidemux PORTREVISION=3D 9 found, bumping it by 1. INFO: multimedia/avidemux-cli PORTREVISION not found, adding PORTREVISION= =3D 1 ERROR: multimedia/avidemux-cli PORTREVISION went backwards from 5 to 1! INFO: multimedia/avidemux-plugins PORTREVISION not found, adding PORTREVISION=3D 1=20 ERROR: multimedia/avidemux-plugins PORTREVISION went backwards from 5 to = 1! INFO: multimedia/avidemux-qt4 PORTREVISION not found, adding PORTREVISION= =3D 1 ERROR: multimedia/avidemux-qt4 PORTREVISION went backwards from 5 to 1! The beauty of my approach is that it uses a different approach than simple text search, and the one that the ports framework actually uses when it run= s. Happy to tweak that patch, otherwise also happy to commit this if you approve.