From owner-freebsd-bugs@FreeBSD.ORG Sat Mar 13 07:40:06 2010 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 246791065676 for ; Sat, 13 Mar 2010 07:40:06 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 142BF8FC0C for ; Sat, 13 Mar 2010 07:40:06 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o2D7e5M1097776 for ; Sat, 13 Mar 2010 07:40:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o2D7e5lM097775; Sat, 13 Mar 2010 07:40:05 GMT (envelope-from gnats) Date: Sat, 13 Mar 2010 07:40:05 GMT Message-Id: <201003130740.o2D7e5lM097775@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Garrett Cooper Cc: Subject: Re: bin/144644: [patch] Fix *alloc cornercases with config(1) X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Garrett Cooper List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Mar 2010 07:40:06 -0000 The following reply was made to PR bin/144644; it has been noted by GNATS. From: Garrett Cooper To: bug-followup@freebsd.org, gcooper@freebsd.org Cc: Subject: Re: bin/144644: [patch] Fix *alloc cornercases with config(1) Date: Fri, 12 Mar 2010 23:36:52 -0800 --001636d34fdc29c6250481a9b61f Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On Fri, Mar 12, 2010 at 11:28 PM, Garrett Cooper wrote= : > =A0 =A0The attached patch addresses the non-style(9) conformity with my > previous patch as pointed out by several folks on current@. Sorry -- missed a spot... Thanks, -Garrett --001636d34fdc29c6250481a9b61f Content-Type: text/plain; charset=US-ASCII; name="config-failure-corner-cases.diff.txt" Content-Disposition: attachment; filename="config-failure-corner-cases.diff.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_g6q3s32n1 SW5kZXg6IG1rb3B0aW9ucy5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIG1rb3B0aW9ucy5jCShyZXZpc2lvbiAy MDUxMTUpCisrKyBta29wdGlvbnMuYwkod29ya2luZyBjb3B5KQpAQCAtNzAsNiArNzAsOCBAQAog CS8qIEZha2UgdGhlIGNwdSB0eXBlcyBhcyBvcHRpb25zLiAqLwogCVNMSVNUX0ZPUkVBQ0goY3As ICZjcHV0eXBlLCBjcHVfbmV4dCkgewogCQlvcCA9IChzdHJ1Y3Qgb3B0ICopY2FsbG9jKDEsIHNp emVvZigqb3ApKTsKKwkJaWYgKG9wID09IE5VTEwpCisJCQllcnJ4KEVYSVRfRkFJTFVSRSwgImNh bGxvYyIpOwogCQlvcC0+b3BfbmFtZSA9IG5zKGNwLT5jcHVfbmFtZSk7CiAJCVNMSVNUX0lOU0VS VF9IRUFEKCZvcHQsIG9wLCBvcF9uZXh0KTsKIAl9CQpAQCAtODQsNiArODYsOCBAQAogCiAJLyog RmFrZSBNQVhVU0VSUyBhcyBhbiBvcHRpb24uICovCiAJb3AgPSAoc3RydWN0IG9wdCAqKWNhbGxv YygxLCBzaXplb2YoKm9wKSk7CisJaWYgKG9wID09IE5VTEwpCisJCWVycngoRVhJVF9GQUlMVVJF LCAiY2FsbG9jIik7CiAJb3AtPm9wX25hbWUgPSBucygiTUFYVVNFUlMiKTsKIAlzbnByaW50Zihi dWYsIHNpemVvZihidWYpLCAiJWQiLCBtYXh1c2Vycyk7CiAJb3AtPm9wX3ZhbHVlID0gbnMoYnVm KTsKQEAgLTE5OSw2ICsyMDMsOCBAQAogCQkJdGlkeSsrOwogCQl9IGVsc2UgewogCQkJb3AgPSAo c3RydWN0IG9wdCAqKSBjYWxsb2MoMSwgc2l6ZW9mICpvcCk7CisJCQlpZiAob3AgPT0gTlVMTCkK KwkJCQllcnJ4KEVYSVRfRkFJTFVSRSwgImNhbGxvYyIpOwogCQkJb3AtPm9wX25hbWUgPSBpbnc7 CiAJCQlvcC0+b3BfdmFsdWUgPSBpbnZhbHVlOwogCQkJU0xJU1RfSU5TRVJUX0hFQUQoJm9wX2hl YWQsIG9wLCBvcF9uZXh0KTsKQEAgLTIyNSw2ICsyMzEsOCBAQAogCWlmICh2YWx1ZSAmJiAhc2Vl bikgewogCQkvKiBOZXcgb3B0aW9uIGFwcGVhcnMgKi8KIAkJb3AgPSAoc3RydWN0IG9wdCAqKSBj YWxsb2MoMSwgc2l6ZW9mICpvcCk7CisJCWlmIChvcCA9PSBOVUxMKQorCQkJZXJyeChFWElUX0ZB SUxVUkUsICJjYWxsb2MiKTsKIAkJb3AtPm9wX25hbWUgPSBucyhuYW1lKTsKIAkJb3AtPm9wX3Zh bHVlID0gdmFsdWUgPyBucyh2YWx1ZSkgOiBOVUxMOwogCQlTTElTVF9JTlNFUlRfSEVBRCgmb3Bf aGVhZCwgb3AsIG9wX25leHQpOwpAQCAtMzM2LDYgKzM0NCw4IEBACiAJfQogCQogCXBvID0gKHN0 cnVjdCBvcHRfbGlzdCAqKSBjYWxsb2MoMSwgc2l6ZW9mICpwbyk7CisJaWYgKHBvID09IE5VTEwp CisJCWVycngoRVhJVF9GQUlMVVJFLCAiY2FsbG9jIik7CiAJcG8tPm9fbmFtZSA9IHRoaXM7CiAJ cG8tPm9fZmlsZSA9IHZhbDsKIAlTTElTVF9JTlNFUlRfSEVBRCgmb3RhYiwgcG8sIG9fbmV4dCk7 CkluZGV4OiBtYWluLmMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbWFpbi5jCShyZXZpc2lvbiAyMDUxMTUpCisr KyBtYWluLmMJKHdvcmtpbmcgY29weSkKQEAgLTEyMCw3ICsxMjAsNyBAQAogCQkJaWYgKCpkZXN0 ZGlyID09ICdcMCcpCiAJCQkJc3RybGNweShkZXN0ZGlyLCBvcHRhcmcsIHNpemVvZihkZXN0ZGly KSk7CiAJCQllbHNlCi0JCQkJZXJyeCgyLCAiZGlyZWN0b3J5IGFscmVhZHkgc2V0Iik7CisJCQkJ ZXJyeChFWElUX0ZBSUxVUkUsICJkaXJlY3RvcnkgYWxyZWFkeSBzZXQiKTsKIAkJCWJyZWFrOwog CQljYXNlICdnJzoKIAkJCWRlYnVnZ2luZysrOwpAQCAtMTc1LDcgKzE3NSw3IEBACiAJCWlmICht a2RpcihwLCAwNzc3KSkKIAkJCWVycigyLCAiJXMiLCBwKTsKIAl9IGVsc2UgaWYgKCFTX0lTRElS KGJ1Zi5zdF9tb2RlKSkKLQkJZXJyeCgyLCAiJXMgaXNuJ3QgYSBkaXJlY3RvcnkiLCBwKTsKKwkJ ZXJyeChFWElUX0ZBSUxVUkUsICIlcyBpc24ndCBhIGRpcmVjdG9yeSIsIHApOwogCiAJU0xJU1Rf SU5JVCgmY3B1dHlwZSk7CiAJU0xJU1RfSU5JVCgmbWtvcHQpOwpAQCAtMjU2LDcgKzI1Niw3IEBA CiAJaW50IGk7CiAKIAlpZiAocmVhbHBhdGgoIi4uLy4uIiwgc3JjZGlyKSA9PSBOVUxMKQotCQll cnJ4KDIsICJVbmFibGUgdG8gZmluZCByb290IG9mIHNvdXJjZSB0cmVlIik7CisJCWVycngoRVhJ VF9GQUlMVVJFLCAiVW5hYmxlIHRvIGZpbmQgcm9vdCBvZiBzb3VyY2UgdHJlZSIpOwogCWlmICgo cHdkID0gZ2V0ZW52KCJQV0QiKSkgIT0gTlVMTCAmJiAqcHdkID09ICcvJyAmJgogCSAgICAocHdk ID0gc3RyZHVwKHB3ZCkpICE9IE5VTEwpIHsKIAkJLyogUmVtb3ZlIHRoZSBsYXN0IHR3byBwYXRo IGNvbXBvbmVudHMuICovCkBAIC02NTAsNiArNjUwLDggQEAKIAkJfQogCX0KIAlobCA9IGNhbGxv YygxLCBzaXplb2YoKmhsKSk7CisJaWYgKGhsID09IE5VTEwpCisJCWVycngoRVhJVF9GQUlMVVJF LCAiY2FsbG9jIik7CiAJaGwtPmhfbmFtZSA9IHM7CiAJaGwtPmhfbmV4dCA9IGh0YWI7CiAJaHRh YiA9IGhsOwpJbmRleDogbWttYWtlZmlsZS5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIG1rbWFrZWZpbGUuYwko cmV2aXNpb24gMjA1MTE1KQorKysgbWttYWtlZmlsZS5jCSh3b3JraW5nIGNvcHkpCkBAIC05OCw2 ICs5OCw4IEBACiAJc3RydWN0IGZpbGVfbGlzdCAqZnA7CiAKIAlmcCA9IChzdHJ1Y3QgZmlsZV9s aXN0ICopIGNhbGxvYygxLCBzaXplb2YgKmZwKTsKKwlpZiAoZnAgPT0gTlVMTCkKKwkJZXJyeChF WElUX0ZBSUxVUkUsICJjYWxsb2MiKTsKIAlTVEFJTFFfSU5TRVJUX1RBSUwoJmZ0YWIsIGZwLCBm X25leHQpOwogCXJldHVybiAoZnApOwogfQpJbmRleDogbGFuZy5sCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGxh bmcubAkocmV2aXNpb24gMjA1MTE1KQorKysgbGFuZy5sCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2 ICszMSw3IEBACiAgKiAkRnJlZUJTRCQKICAqLwogCisjaW5jbHVkZSA8ZXJyLmg+CiAjaW5jbHVk ZSA8YXNzZXJ0Lmg+CiAjaW5jbHVkZSA8Y3R5cGUuaD4KICNpbmNsdWRlIDxzdHJpbmcuaD4KQEAg LTIyMCw2ICsyMjEsOCBAQAogCXN0cnVjdCBjZmdmaWxlICpjZjsKIAogCWNmID0gY2FsbG9jKDEs IHNpemVvZigqY2YpKTsKKwlpZiAoY2YgPT0gTlVMTCkKKwkJZXJyeChFWElUX0ZBSUxVUkUsICJj YWxsb2MiKTsKIAlhc3NlcnQoY2YgIT0gTlVMTCk7CiAJYXNwcmludGYoJmNmLT5jZmdfcGF0aCwg IiVzIiwgZm5hbWUpOwogCVNUQUlMUV9JTlNFUlRfVEFJTCgmY2ZnZmlsZXMsIGNmLCBjZmdfbmV4 dCk7CkluZGV4OiBjb25maWcueQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBjb25maWcueQkocmV2aXNpb24gMjA1 MTE1KQorKysgY29uZmlnLnkJKHdvcmtpbmcgY29weSkKQEAgLTE2Niw2ICsxNjYsOCBAQAogCUNQ VSBTYXZlX2lkIHsKIAkJc3RydWN0IGNwdXR5cGUgKmNwID0KIAkJICAgIChzdHJ1Y3QgY3B1dHlw ZSAqKWNhbGxvYygxLCBzaXplb2YgKHN0cnVjdCBjcHV0eXBlKSk7CisJCWlmIChjcCA9PSBOVUxM KQorCQkJZXJyeChFWElUX0ZBSUxVUkUsICJjYWxsb2MiKTsKIAkJY3AtPmNwdV9uYW1lID0gJDI7 CiAJCVNMSVNUX0lOU0VSVF9IRUFEKCZjcHV0eXBlLCBjcCwgY3B1X25leHQpOwogCSAgICAgIH0g fApAQCAtMTk3LDYgKzE5OSw4IEBACiAJCXN0cnVjdCBoaW50ICpoaW50OwogCiAJCWhpbnQgPSAo c3RydWN0IGhpbnQgKiljYWxsb2MoMSwgc2l6ZW9mIChzdHJ1Y3QgaGludCkpOworCQlpZiAoaGlu dCA9PSBOVUxMKQorCQkJZXJyeChFWElUX0ZBSUxVUkUsICJjYWxsb2MiKTsJCiAJCWhpbnQtPmhp bnRfbmFtZSA9ICQyOwogCQlTVEFJTFFfSU5TRVJUX1RBSUwoJmhpbnRzLCBoaW50LCBoaW50X25l eHQpOwogCQloaW50bW9kZSA9IDE7CkBAIC0zMzEsNiArMzM1LDggQEAKIAlzdHJ1Y3QgZmlsZXNf bmFtZSAqbmw7CiAJCiAJbmwgPSAoc3RydWN0IGZpbGVzX25hbWUgKikgY2FsbG9jKDEsIHNpemVv ZiAqbmwpOworCWlmIChubCA9PSBOVUxMKQorCQllcnJ4KEVYSVRfRkFJTFVSRSwgImNhbGxvYyIp OwogCW5sLT5mX25hbWUgPSBuYW1lOwogCVNUQUlMUV9JTlNFUlRfVEFJTCgmZm50YWIsIG5sLCBm X25leHQpOwogfQpAQCAtMzY0LDYgKzM3MCw4IEBACiAJfQogCiAJbnAgPSAoc3RydWN0IGRldmlj ZSAqKSBjYWxsb2MoMSwgc2l6ZW9mICpucCk7CisJaWYgKG5wID09IE5VTEwpCisJCWVycngoRVhJ VF9GQUlMVVJFLCAiY2FsbG9jIik7CiAJbnAtPmRfbmFtZSA9IG5hbWU7CiAJU1RBSUxRX0lOU0VS VF9UQUlMKCZkdGFiLCBucCwgZF9uZXh0KTsKIH0KQEAgLTQyMiw2ICs0MzAsOCBAQAogCX0KIAog CW9wID0gKHN0cnVjdCBvcHQgKiljYWxsb2MoMSwgc2l6ZW9mIChzdHJ1Y3Qgb3B0KSk7CisJaWYg KG9wID09IE5VTEwpCisJCWVycngoRVhJVF9GQUlMVVJFLCAiY2FsbG9jIik7CiAJb3AtPm9wX25h bWUgPSBuYW1lOwogCW9wLT5vcF9vd25maWxlID0gMDsKIAlvcC0+b3BfdmFsdWUgPSB2YWx1ZTsK --001636d34fdc29c6250481a9b61f--