From owner-svn-src-head@freebsd.org Wed Aug 22 16:08:12 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 53950108D0D0; Wed, 22 Aug 2018 16:08:12 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id AF3347BA62; Wed, 22 Aug 2018 16:08:11 +0000 (UTC) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id w7MG894Q085119; Wed, 22 Aug 2018 09:08:09 -0700 (PDT) (envelope-from freebsd@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id w7MG89vW085118; Wed, 22 Aug 2018 09:08:09 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201808221608.w7MG89vW085118@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r338172 - Now deprecating DRM In-Reply-To: To: Matthew Macy Date: Wed, 22 Aug 2018 09:08:09 -0700 (PDT) CC: rgrimes@freebsd.org, src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Aug 2018 16:08:12 -0000 > > > > Could you please create a stable/11 deprecation change. > > > > What does that entail other than an update to UPDATING in stable/11? I see some others have answered on this, so I'll just summarize. 1) Calls to gone_in should be added to the stable/11 drm modules so that when they are loaded a message informs the user of the deprecation. Please be sure to tag this commit with Relnotes: Y 2) No note is needed in UPDATING, as there is not any action for the user to take in stable/11, the UPDATING note was done in head, which is correct. 3) If for some reason you make another DRM removal related commit to head please add a tag for Relnotes: Y as this needs to be in the 12.0 release notes too. Thats all I can think of right now, as a future request, and IMHO, all deprecations should have a formal review process, no mater who approved it. There are just so many bits and pieces that need done to make sure these work smoothly as possible. For example, the gone_in stuff was desinged so that should of been the first commit, in ^head, and then merged to stable/11. All commits adding gone_in should be tagged with relnotes Y so good notification goes out. Desirably these gone-in's should be in existing for a full point release, so that we do not abondon uses that was not considered, this DRM one seems to have rather serious impacts on a couple of users. I think this deprecation is a rather serious deviation from the stated policy, in that 0 notification was made, core IMHO, has overstepped some boundaries in that respect. These policies are promises to the downstream consumers, and violating them is very poor planning. -- Rod Grimes rgrimes@freebsd.org