From owner-svn-ports-all@FreeBSD.ORG Tue Dec 3 03:06:27 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id B7F4A5BF; Tue, 3 Dec 2013 03:06:27 +0000 (UTC) Received: from apnoea.adamw.org (apnoea.adamw.org [204.109.59.150]) (using TLSv1 with cipher ADH-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 89E871FDD; Tue, 3 Dec 2013 03:06:27 +0000 (UTC) Received: by apnoea.adamw.org (Postfix, from userid 1002) id 876B8120034; Mon, 2 Dec 2013 20:59:55 -0500 (EST) Date: Mon, 2 Dec 2013 20:59:55 -0500 From: Adam Weinberger To: Mark Linimon Subject: Re: svn commit: r335281 - in head: . audio audio/gnump3d Message-ID: <20131203015955.GA55963@apnoea.adamw.org> References: <529C5F05.6020706@marino.st> <20131202104324.GB71618@tuxaco.net> <529C689B.9050902@marino.st> <20131202131244.GC71618@tuxaco.net> <529C8C1F.7050802@marino.st> <20131202134921.GD71618@tuxaco.net> <529C91F2.6020004@marino.st> <20131202145224.GH71618@tuxaco.net> <529CA16C.2060000@marino.st> <20131202184749.GC30485@lonesome.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20131202184749.GC30485@lonesome.com> X-Editor: Vim 7.3 http://www.vim.org X-Mailer: Mutt 1.5 http://www.mutt.org X-Adamw: ADAMW!!! X-URL: http://www.adamw.org User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, marino@freebsd.org, ports-committers@freebsd.org, Philippe =?iso-8859-1?Q?Aud=E9oud?= , Rene Ladan , John Marino X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Dec 2013 03:06:27 -0000 >> (2013/12/02 @ 1347 EST): Mark Linimon said, in 1.5K: << > My reasoning is that contributing to FreeBSD is sometimes > hard and thankless, and if someone just hears too much negative feedback, > they may just find something else better to do. >> end of "Re: svn commit: r335281 - in head: . audio audio/gnump3d" from Mark Linimon << The style police (I'm looking at you, Alexey) should be allowed to fix commits for "correctness," and committers should be allowed to fix obvious mistakes for each other. 1) You have the confidence that if you accidentally commit something with an obvious error, someone is likely to help you out and fix it for you. 2) You don't have to sit there and stew when a commit accidentally breaks that port you love. Because let's face it, nobody wants to file a PR for ${PORT_OPTIONS:MODCS}. 3) If everybody is empowered to fix obvious mistakes and style nits, you gain a consistent experience for the end-user, who we all theoretically work for. You know, rather than just having Alexey send you an email about the importance of not muting install commands, which everybody seems to ignore anyway. 4) People need to un-knot their panties. Seriously. We're talking about "but *I* wanted to delete that port!" Someone did your work for you. Think about all the things you could do with the 30 seconds they just saved you. But when faced with the choice between "let's all fix bugs and promote a consistent ports user experience" and "MINE!", we all know which one people will pick. # Adam -- Adam Weinberger adamw@adamw.org http://www.adamw.org