From owner-svn-src-all@freebsd.org  Thu Mar 17 04:12:11 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id AB151AD21FB;
 Thu, 17 Mar 2016 04:12:11 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 9AF7210F;
 Thu, 17 Mar 2016 04:12:11 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [IPv6:::1])
 by freefall.freebsd.org (Postfix) with ESMTP id 947471459;
 Thu, 17 Mar 2016 04:12:11 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [172.31.3.2])
 by mail.xzibition.com (Postfix) with ESMTP id 5371F1F923;
 Thu, 17 Mar 2016 04:12:11 +0000 (UTC)
X-Virus-Scanned: amavisd-new at mail.xzibition.com
Received: from mail.xzibition.com ([172.31.3.2])
 by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new,
 port 10026)
 with LMTP id EH8g-12kgqS6; Thu, 17 Mar 2016 04:12:04 +0000 (UTC)
Subject: Re: svn commit: r296970 - head/lib/libxo/tests
DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 395751F91D
To: "Simon J. Gerraty" <sjg@juniper.net>, NGie Cooper <yaneurabeya@gmail.com>
References: <201603170037.u2H0b4Rb082849@repo.freebsd.org>
 <984878F0-9CE9-442D-8F7F-40C5365052AA@gmail.com>
 <85789.1458187497@kaos.jnpr.net>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
From: Bryan Drewery <bdrewery@FreeBSD.org>
Organization: FreeBSD
Message-ID: <56EA2E93.2020406@FreeBSD.org>
Date: Wed, 16 Mar 2016 21:12:03 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.7.0
MIME-Version: 1.0
In-Reply-To: <85789.1458187497@kaos.jnpr.net>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.21
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 17 Mar 2016 04:12:11 -0000

On 3/16/16 9:04 PM, Simon J. Gerraty wrote:
> NGie Cooper <yaneurabeya@gmail.com> wrote:
>>> SUBDIR+=    encoder
>>>
>>> +.if ${MACHINE} == "host"
>>> +# make it easy to test without install
>>> +TESTSDIR=    ${.OBJDIR}
>>> +CFLAGS+=    -I${.CURDIR:H}
>>> +.endif
>>> +
>>> .include <bsd.test.mk>
>>
>> This commit seems unnecessary -- have you tried make check yet?
> 
> That appears to require installing things before you test that they
> work - seems a bit backwards?
> 
> Note the above is only relevant when building with DIRDEPS.
> Where we want to be able to build and run relevant tests as part of the
> build as we go - when MACHINE = "host" that is.
> 
> Phil wants to fix this so that it runs all his test suite properly and
> also need to arrange to auto-update the makefile here as new tests are
> added to the distribution.
> Probably need somthing like bmake's after-import target.
> 
> Anyway, being able to have this work in context of DIRDEPS_BUILD will
> help (I haven't added the MK_TESTS hooks yet).
> 
> 

Btw I recently hooked up MK_TESTS to DIRDEPS_BUILD and added them all
(at the time) to targets/.

-- 
Regards,
Bryan Drewery