From owner-svn-src-head@freebsd.org  Sun Mar 25 17:00:19 2018
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C9984F59116
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Sun, 25 Mar 2018 17:00:19 +0000 (UTC) (envelope-from ian@freebsd.org)
Received: from pmta2.delivery6.ore.mailhop.org
 (pmta2.delivery6.ore.mailhop.org [54.200.129.228])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 4E42A6DBE0
 for <svn-src-head@freebsd.org>; Sun, 25 Mar 2018 17:00:18 +0000 (UTC)
 (envelope-from ian@freebsd.org)
X-MHO-User: d67c3236-304d-11e8-b951-f99fef315fd9
X-Report-Abuse-To: https://support.duocircle.com/support/solutions/articles/5000540958-duocircle-standard-smtp-abuse-information
X-Originating-IP: 67.177.211.60
X-Mail-Handler: DuoCircle Outbound SMTP
Received: from ilsoft.org (unknown [67.177.211.60])
 by outbound2.ore.mailhop.org (Halon) with ESMTPSA
 id d67c3236-304d-11e8-b951-f99fef315fd9;
 Sun, 25 Mar 2018 16:59:10 +0000 (UTC)
Received: from rev (rev [172.22.42.240])
 by ilsoft.org (8.15.2/8.15.2) with ESMTP id w2PH0GoE055165;
 Sun, 25 Mar 2018 11:00:16 -0600 (MDT) (envelope-from ian@freebsd.org)
Message-ID: <1521997216.49673.2.camel@freebsd.org>
Subject: Re: svn commit: r331532 - head/sys/crypto/ccp
From: Ian Lepore <ian@freebsd.org>
To: Warner Losh <imp@FreeBSD.org>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Date: Sun, 25 Mar 2018 11:00:16 -0600
In-Reply-To: <201803251656.w2PGunC0061278@repo.freebsd.org>
References: <201803251656.w2PGunC0061278@repo.freebsd.org>
Content-Type: text/plain; charset="ISO-8859-1"
X-Mailer: Evolution 3.18.5.1 FreeBSD GNOME Team Port 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 25 Mar 2018 17:00:20 -0000

On Sun, 2018-03-25 at 16:56 +0000, Warner Losh wrote:
> Author: imp
> Date: Sun Mar 25 16:56:49 2018
> New Revision: 331532
> URL: https://svnweb.freebsd.org/changeset/base/331532
> 
> Log:
>   The PNP info has to follow the module definition. Move it from just
>   after the array to its proper location. Otherwise, the linker.hints
>   file has things out of order and we associated it with whatever was
>   the previous module.

Wow, that seems like a subtle thing that'll be easy to get wrong and
hard to detect when you have.  Would it be possible for the PNP macro
to have some kind of reference to the structures generated by the
module definition macro, to force a compile-time error if they're out
of order?

-- Ian