From owner-svn-src-all@freebsd.org Sun Dec 15 19:44:50 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 28A391CCD20; Sun, 15 Dec 2019 19:44:50 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47bZcK0WWzz3N3v; Sun, 15 Dec 2019 19:44:48 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id xBFJijxl090592; Sun, 15 Dec 2019 11:44:45 -0800 (PST) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id xBFJijrq090591; Sun, 15 Dec 2019 11:44:45 -0800 (PST) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <201912151944.xBFJijrq090591@gndrsh.dnsmgr.net> Subject: Re: svn commit: r355692 - head/sbin/fsirand In-Reply-To: <201912130412.xBD4CDZm017850@repo.freebsd.org> To: Conrad Meyer Date: Sun, 15 Dec 2019 11:44:45 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Reply-To: rgrimes@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 47bZcK0WWzz3N3v X-Spamd-Bar: + Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=none (mx1.freebsd.org: domain of freebsd@gndrsh.dnsmgr.net has no SPF policy when checking 69.59.192.140) smtp.mailfrom=freebsd@gndrsh.dnsmgr.net X-Spamd-Result: default: False [1.14 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[rgrimes@freebsd.org]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; RCVD_TLS_LAST(0.00)[]; DMARC_NA(0.00)[dnsmgr.net]; AUTH_NA(1.00)[]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; NEURAL_SPAM_MEDIUM(0.15)[0.148,0]; IP_SCORE(0.04)[ip: (0.14), ipnet: 69.59.192.0/19(0.07), asn: 13868(0.02), country: US(-0.05)]; NEURAL_SPAM_LONG(0.05)[0.054,0]; R_SPF_NA(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:13868, ipnet:69.59.192.0/19, country:US]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_COUNT_TWO(0.00)[2] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Dec 2019 19:44:50 -0000 > Author: cem > Date: Fri Dec 13 04:12:13 2019 > New Revision: 355692 > URL: https://svnweb.freebsd.org/changeset/base/355692 > > Log: > fsirand(8): Just use arc4random(3) > > Remove single use of dubious srandomdev(3) + random(3) and replace with > arc4random(3), as is used already in this program. > > Follow-up question: Do we really need this program anymore? In base? The proper place to ask that is on -arch, not a commit message. > Modified: > head/sbin/fsirand/fsirand.c > > Modified: head/sbin/fsirand/fsirand.c > ============================================================================== > --- head/sbin/fsirand/fsirand.c Fri Dec 13 04:03:05 2019 (r355691) > +++ head/sbin/fsirand/fsirand.c Fri Dec 13 04:12:13 2019 (r355692) > @@ -83,8 +83,6 @@ main(int argc, char *argv[]) > if (argc - optind < 1) > usage(); > > - srandomdev(); > - > /* Increase our data size to the max */ > if (getrlimit(RLIMIT_DATA, &rl) == 0) { > rl.rlim_cur = rl.rlim_max; > @@ -167,7 +165,7 @@ fsirand(char *device) > if (!printonly) { > /* Randomize fs_id and write out new sblock and backups */ > sblock->fs_id[0] = (u_int32_t)time(NULL); > - sblock->fs_id[1] = random(); > + sblock->fs_id[1] = arc4random(); > if (sbput(devfd, sblock, sblock->fs_ncg) != 0) { > warn("could not write updated superblock"); > return (1); > -- Rod Grimes rgrimes@freebsd.org