From owner-cvs-all@FreeBSD.ORG Thu Oct 25 19:17:42 2007 Return-Path: <owner-cvs-all@FreeBSD.ORG> Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C9C7516A419; Thu, 25 Oct 2007 19:17:42 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from mail.netplex.net (mail.netplex.net [204.213.176.10]) by mx1.freebsd.org (Postfix) with ESMTP id 1208D13C48E; Thu, 25 Oct 2007 19:17:41 +0000 (UTC) (envelope-from deischen@freebsd.org) Received: from sea.ntplx.net (sea.ntplx.net [204.213.176.11]) by mail.netplex.net (8.14.1/8.14.1/NETPLEX) with ESMTP id l9PJHWuG021340; Thu, 25 Oct 2007 15:17:32 -0400 (EDT) X-Virus-Scanned: by AMaViS and Clam AntiVirus (mail.netplex.net) X-Greylist: Message whitelisted by DRAC access database, not delayed by milter-greylist-3.0 (mail.netplex.net [204.213.176.10]); Thu, 25 Oct 2007 15:17:32 -0400 (EDT) Date: Thu, 25 Oct 2007 15:17:32 -0400 (EDT) From: Daniel Eischen <deischen@freebsd.org> X-X-Sender: eischen@sea.ntplx.net To: d@delphij.net In-Reply-To: <4720E9E1.7000900@delphij.net> Message-ID: <Pine.GSO.4.64.0710251516220.29092@sea.ntplx.net> References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <4720B30F.4040903@samsco.org> <20071025151707.GA11398@nagual.pp.ru> <4720C7D6.9090004@delphij.net> <20071025190019.GA16187@nagual.pp.ru> <4720E9E1.7000900@delphij.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: Andrey Chernov <ache@nagual.pp.ru>, Scott Long <scottl@samsco.org>, src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Daniel Eischen <deischen@freebsd.org> List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org> List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>, <mailto:cvs-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/cvs-all> List-Post: <mailto:cvs-all@freebsd.org> List-Help: <mailto:cvs-all-request@freebsd.org?subject=help> List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>, <mailto:cvs-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Thu, 25 Oct 2007 19:17:42 -0000 On Thu, 25 Oct 2007, LI Xin wrote: > Andrey Chernov wrote: >> On Thu, Oct 25, 2007 at 09:44:06AM -0700, LI Xin wrote: >>> Andrey Chernov wrote: >>>> On Thu, Oct 25, 2007 at 09:15:27AM -0600, Scott Long wrote: >>>>> Andrey A. Chernov wrote: >>>>>> ache 2007-10-15 09:51:30 UTC >>>>>> FreeBSD src repository >>>>>> Modified files: >>>>>> lib/libc/locale utf8.c Log: >>>>>> Add comment explaining __mb_sb_limit trick here. >>>>>> Revision Changes Path >>>>>> 1.16 +5 -0 src/lib/libc/locale/utf8.c >>>>> When is the ABI damage from this going to be fixed? >>>> There is no ABI damage in -current. >>> Do we really need to expose __mb_sb_limit outside libc? >> >> Yes, it is used in inlines compiled each time ctype.h included. > > Yes, I noticed that. So the problem would be, if a program has included > ctype.h (_ctype.h) then it has the potential to require the symbol, > which does not exist in previous releases. > > Having __inline functions sounds reasonable to me, though, because these > functions are really small and may be called frequently. Maybe we can > think out a way of avoiding the addition? It sounds like that > potentially we will have trouble running binaries compiled on 6.3-R on > 6.2-R systems, while this is acceptable IMO it is not very interesting > for user community :-) Why not simply avoid the error check for inlines. Solaris doesn't seem to add a check, it just does the conversion. The non-inlined versions do error checking. -- DE