From owner-cvs-all@FreeBSD.ORG  Wed Oct 22 21:08:44 2003
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id D31DA16A4C4; Wed, 22 Oct 2003 21:08:43 -0700 (PDT)
Received: from dommail.onthenet.com.au (dommail.OntheNet.com.au
	[203.13.70.57])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id CE90443F3F; Wed, 22 Oct 2003 21:08:38 -0700 (PDT)
	(envelope-from grehan@freebsd.org)
Received: from freebsd.org (CPE-203-45-244-178.qld.bigpond.net.au
	[203.45.244.178])
	by dommail.onthenet.com.au (Mirapoint Messaging Server MOS 3.2.4-GA)
	with ESMTP id ABV65409 (AUTH peterg@ptree32.com.au);
	Thu, 23 Oct 2003 14:08:36 +1000 (EST)
Sender: grehan@dommail.onthenet.com.au
Message-ID: <3F975466.A8B543B6@freebsd.org>
Date: Thu, 23 Oct 2003 14:09:10 +1000
From: Peter Grehan <grehan@freebsd.org>
X-Mailer: Mozilla 4.79 [en] (X11; U; Linux 2.2.14-12 i686)
X-Accept-Language: en
MIME-Version: 1.0
To: Hajimu UMEMOTO <ume@freebsd.org>
References: <200310221510.h9MFAdwZ092987@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
cc: cvs-src@freebsd.org
cc: src-committers@freebsd.org
cc: cvs-all@freebsd.org
Subject: Re: cvs commit: src/sys/net if.c
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 23 Oct 2003 04:08:44 -0000

>   Modified files:
>     sys/net              if.c
>   Log:
>   protect by IFNET_RLOCK.
> 
>   Revision  Changes    Path
>   1.169     +2 -0      src/sys/net/if.c

 This causes a witness warning:

>malloc() of "16" with the following non-sleepable locks held:
>exclusive sleep mutex ifnet r = 0 (0x418ac8) locked @ /mnt/home/freebsd/src/sys/net/if.c:463
>Welcome to Debugger, witness_warn
>db> t
>0x003aae50: at witness_warn+0x238
>0x003aaf00: at uma_zalloc_arg+0xcc
>0x003aaf30: at malloc+0xfc
>0x003aaf60: at in6_domifattach+0x2c
>0x003aaf90: at if_attachdomain1+0x58
>0x003aafb0: at if_attachdomain+0x40
>0x003aafd0: at mi_startup+0x128

 in6_domifattach() mallocs with WAITOK, so I think these calls should be changed
to use M_NOWAIT, or an alternative ifnet list locking strategy used.

later,

Peter.