Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 01 Jun 2012 03:12:42 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        "Simon L. B. Nielsen" <simon@qxnitro.org>
Cc:        Eitan Adler <eadler@freebsd.org>, freebsd-doc@freebsd.org, wblock@freebsd.org, Thierry Thomas <thierry@freebsd.org>, Jason Helfman <jgh@freebsd.org>
Subject:   Re: cvs commit: ports/security/vuxml vuln.xml
Message-ID:  <4FC8959A.8020008@FreeBSD.org>
In-Reply-To: <CAC8HS2FfQzYL69cidQzN1JmvyYRsv2AnaXm6TNr1QfLj1JmN%2BA@mail.gmail.com>
References:  <201205302046.q4UKka2f062416@repoman.freebsd.org> <CAF6rxgnqRU5J=B5KDvm_h1XE9fQ3FzOEqUMWQnLL7XN7SrWnOg@mail.gmail.com> <20120530222837.GA94334@dormouse.experts-exchange.com> <CAF6rxgnuTQwXHi09yczTrQwEtCAk16UjFFEtYVsJ2LoL2aaJ4g@mail.gmail.com> <CAMuy=%2BjOSurM7x4fekC6%2BsHp2ovJCyK%2BHXdb8_ADtywRuEyQBA@mail.gmail.com> <alpine.BSF.2.00.1205311023290.83108@wonkity.com> <4FC7BDE9.40602@FreeBSD.org> <alpine.BSF.2.00.1205311405010.83987@wonkity.com> <4FC814BB.90507@FreeBSD.org> <CAC8HS2FfQzYL69cidQzN1JmvyYRsv2AnaXm6TNr1QfLj1JmN%2BA@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 06/01/2012 02:55, Simon L. B. Nielsen wrote:
> On Fri, Jun 1, 2012 at 2:02 AM, Doug Barton <dougb@freebsd.org> wrote:
>>> On Thu, 31 May 2012, Doug Barton wrote:
>>>
>>>> On 05/31/2012 09:28 AM, Warren Block wrote:
>>>>> Sorry, I missed the original post and am not quite sure what is being
>>>>> checked.  At present, igor doesn't know XML at all.  My hope is that
>>>>> some existing XML validator can be used to check tagging and indentation
>>>>> of DocBook XML, and igor can just check for documentation-specific
>>>>> problems.
>>>>
>>>> xmllint does a pretty good job of validation. Not sure how much it helps
>>>> with indentation, but it's a good place to start.
>>
>> To amplify that slightly, since "The Fine Manual" leaves something to be
>> desired ...
>>
>> xmllint --noout --dtdvalid http://www.vuxml.org/dtd/vuxml-1/vuxml-11.dtd
>> vuln.xml
>>
>> is what you want to validate that the file matches the DTD (the current
>> version passes). There is no way to use xmllint to "validate the
>> whitespace," but you could theoretically use the --format option as part
>> of 'make validate'. Note, that would require a one-time commit to change
>> the current format into what --format outputs, since they are pretty
>> dramatically different.
> 
> Just a note, DTD check is unfortunately rather far from validating
> that VuXML entries are valid...

Right ... the question I was responding to was, "How can we confirm that
the XML is right?" which is a different question altogether. The wacky
default whitespace conventions that we have for that file could be
"fixed" (where that really means standardized on a differently wacky
schema) by the --format option of xmllint. That would take the "human
error" element out of the whitespace issue altogether, and avoid the
need to validate it since it would always be standard.

Validating against the DTD is probably also a good step to add, since if
it doesn't at least pass that test, further attempts to validate the
entries themselves are probably fruitless.

IOW, adding xmllint to the mix will probably do more good than harm,
although we need to be careful that we understand what it is, and isn't
doing for us.

Doug

-- 

    This .signature sanitized for your protection



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4FC8959A.8020008>