From nobody Sat Jun 20 14:20:29 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4gjGp72syLz6jdNF; Sat, 20 Jun 2026 14:20:31 +0000 (UTC) (envelope-from markj@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4gjGp71xtWz41gg; Sat, 20 Jun 2026 14:20:31 +0000 (UTC) (envelope-from markj@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781965231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VInDpPrwNA6shVDRDlzEBeNQBHKDtTTL3fHj3fbLCLI=; b=Z+P7joPGzLECzmWl86Zz786jUwEZMFcWr3jJdXLgwqJeTPMnjiw9M55mMrpS/tgwBw+O+I tegumYD5wgozRyspL4Oj+S6C1OGL2dTd5H6T7U8kZw3tjZZg7Lb01qVkiWcuxoGbWk61lX I1zflgLKCOL6BAQy186a9F0oU+sPCxw5StdOvXosprBGUfEoAr4n4cs4TP+1wxKYKb6zpk k3WISnWUp9q3aNIukX9pRL+SbXYV+f/M2nUeAeX2eXXOZiEETbimZAIky1RywwkAauXCh8 8OFJ0L4ddFKJ5yrKYroRnLSiq9dBE9NWAWiFaSz84MiY+bkTN3+tnqdjMc+JrA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1781965231; a=rsa-sha256; cv=none; b=Okbt5TzKDcal4McvgyLXubutF8vRqGGpvFARwo12SL/duPEM3lSrQR9228QrWawdTnLtBC L4UXCPKTOskToNon2VqATpzGezdWU/eBVISvRNajwVR2EfHnDf681JNCSktpMaOaq1XxDL K/QJA3Vp2TplBr6MC8rjWDYIopFiKkxcUh2dYh46w+rItngJvgFVywoycGbdeaz/h57g42 IZW5jTPwsFpRGCVhjbRYg+/E3nAqKFRpf0GGTz2AXMeh2VmZ+5gVlOsp1ZGPZVxl/mSoP5 r1iDrTu5uduWzLVYNEdTh2ogSKdx/46WMBJnHy5zE09/i+o0+WkWik1UIGB5hw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1781965231; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VInDpPrwNA6shVDRDlzEBeNQBHKDtTTL3fHj3fbLCLI=; b=o5E1UCYhlUaRI7AxvPuDujYLT7Y0i7vwr7llo2r4CbndYsJ1kGq/a9Q9BJ+Ys9l4jKnykg 5i8Zvut9RJC6U/HfrXBcKe+bnRgW7ZRM3tWPUqwjbot8ZL+MUHBClPGlBYHch+lj5wz161 wQHO1T5PqW6+Adsbgi+sy5GJ3uNI7KOfucham32KCq1LabHzFfXHLW3n0BSJzrA5jCL4oj /0hNWYaiS59emoeJxHNUsBn8xdw8DzFFA9S8YbUMlji/6d9CvNNq/dL/N1L374oobGaBOL lx156ohG+sIMRDnkL3S6GaFkL05CxLsvZh/hQUqGak0ZVTXJ9GdQxQRBrl81Yg== Received: from framework (unknown [216.191.123.185]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: markj) by smtp.freebsd.org (Postfix) with ESMTPSA id 4gjGp66kBVz9jP; Sat, 20 Jun 2026 14:20:30 +0000 (UTC) (envelope-from markj@freebsd.org) Date: Sat, 20 Jun 2026 10:20:29 -0400 From: Mark Johnston To: Warner Losh Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 949804c81909 - main - nvme: Use newbus to ask if a device is storage Message-ID: References: <6a32b7af.3e162.34185707@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6a32b7af.3e162.34185707@gitrepo.freebsd.org> On Wed, Jun 17, 2026 at 03:05:19PM +0000, Warner Losh wrote: > The branch main has been updated by imp: > > URL: https://cgit.FreeBSD.org/src/commit/?id=949804c819096b40210e0b0729e54ba10b79c2e8 > > commit 949804c819096b40210e0b0729e54ba10b79c2e8 > Author: Warner Losh > AuthorDate: 2026-06-17 15:03:31 +0000 > Commit: Warner Losh > CommitDate: 2026-06-17 15:03:31 +0000 > > nvme: Use newbus to ask if a device is storage > > As NVMe is in more places, it has a variety of attachments. On non PCI > busses, we assume we're a storage device. For PCI, we look at the > interface ID. Add newbus glue to make this happen. > > Sponsored by: Netflix > Discussed with: jhb > Reviewed by: adrian > Differential Revision: https://reviews.freebsd.org/D56994 > --- > sys/dev/nvme/nvme_if.m | 15 +++++++++++++++ > sys/dev/nvme/nvme_pci.c | 15 +++++++++++++++ > sys/dev/nvme/nvme_sim.c | 3 +++ > 3 files changed, 33 insertions(+) > > diff --git a/sys/dev/nvme/nvme_if.m b/sys/dev/nvme/nvme_if.m > index 5a06ff112f4c..9705aeb7ce0b 100644 > --- a/sys/dev/nvme/nvme_if.m > +++ b/sys/dev/nvme/nvme_if.m > @@ -12,6 +12,14 @@ HEADER { > #include "dev/nvme/nvme_private.h" > }; > > +CODE { > + static bool > + default_is_storage_device(device_t dev) > + { > + return (true); > + } > +} > + After this commit I see a warning during buildkernel of a GENERIC kernel: nvme_if.c:21:1: warning: unused function 'default_is_storage_device' [-Wunused-function]