From owner-svn-src-all@freebsd.org Wed Sep 23 02:59:28 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 0D1BC3EA639; Wed, 23 Sep 2020 02:59:28 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Bx2vg0YjVz483W; Wed, 23 Sep 2020 02:59:26 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi1-f181.google.com with SMTP id 185so23404764oie.11; Tue, 22 Sep 2020 19:59:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hyt8XJoZKfgydRSz1yV9/iDsnDRB3aCzZoD8PFlCKpk=; b=rXHCkKnOqH5hmLpWGXdae9ffbNRBJwc508L+tgd2oN/ghKvqYo2kog/pxPNjkDh/Ve ilXXqz4/hF8cNV3zaY2j4w+/NisW4bXDl+ra8zSzTntXlw916tGPMPoM/lqyxmtOY7CZ DOCGIwwslvVsuyTeaHS0hXw4sEzMb4SQCvHfYmnptrHKf4OOvrR048ZWGbIgo64mhEUP Aj/GFaD2WQoKb2iZT6H+1DWC5NYKA7JJGpbqAXpAmn6Gf4ZX154b5VS6NEhnEZaf6gYn +Dobpt60Dj2Z6eTrGtPTaRJdPD6dRYRUdYlzSpxUXiW4P/+UWeHbBrFyGuxNuNLCQ4fT 71yA== X-Gm-Message-State: AOAM533F9wAdxA/7TroLRjNUaUKtYMZdWqumU0EcLRixlvpg3sN6wkns ewhda4LsyZPmEBc8zd4sDRyEl1f9G96Q5RvZClDvOUFO X-Google-Smtp-Source: ABdhPJyNzmckeM11rwx3Y1JP0rk95hVRK35iFNMZGkfATQf3X1iFCEcIyHYpcmLDyAcss7GV9zEq7h1482HyhizPQA4= X-Received: by 2002:aca:4b03:: with SMTP id y3mr4664919oia.57.1600829965674; Tue, 22 Sep 2020 19:59:25 -0700 (PDT) MIME-Version: 1.0 References: <202009112049.08BKnavL032212@repo.freebsd.org> In-Reply-To: From: Alan Somers Date: Tue, 22 Sep 2020 20:59:14 -0600 Message-ID: Subject: Re: svn commit: r365643 - head/bin/cp To: Warner Losh Cc: Kyle Evans , Ian Lepore , Mateusz Guzik , src-committers , svn-src-all , svn-src-head X-Rspamd-Queue-Id: 4Bx2vg0YjVz483W X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of asomers@gmail.com designates 209.85.167.181 as permitted sender) smtp.mailfrom=asomers@gmail.com X-Spamd-Result: default: False [-1.65 / 15.00]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; FREEMAIL_CC(0.00)[freebsd.org,gmail.com]; FREEFALL_USER(0.00)[asomers]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-0.96)[-0.965]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DMARC_NA(0.00)[freebsd.org]; ARC_NA(0.00)[]; NEURAL_SPAM_SHORT(0.22)[0.217]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; RCPT_COUNT_SEVEN(0.00)[7]; RCVD_IN_DNSWL_NONE(0.00)[209.85.167.181:from]; NEURAL_HAM_MEDIUM(-0.90)[-0.900]; FORGED_SENDER(0.30)[asomers@freebsd.org,asomers@gmail.com]; RWL_MAILSPIKE_POSSIBLE(0.00)[209.85.167.181:from]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; RCVD_COUNT_TWO(0.00)[2]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FROM_NEQ_ENVFROM(0.00)[asomers@freebsd.org,asomers@gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.33 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Sep 2020 02:59:28 -0000 Go ahead and commit. Consider it reviewed by me. And if I understand correctly, this commit means there's no need for a special updating procedure, right? On Tue, Sep 22, 2020 at 6:55 PM Warner Losh wrote: > > > On Tue, Sep 22, 2020 at 5:17 PM Kyle Evans wrote: > >> On Tue, Sep 22, 2020, 17:02 Warner Losh wrote: >> >>> >>> >>> On Tue, Sep 22, 2020 at 3:55 PM Kyle Evans wrote: >>> >>>> On Tue, Sep 22, 2020 at 4:53 PM Ian Lepore wrote: >>>> > >>>> > On Tue, 2020-09-22 at 15:50 -0600, Warner Losh wrote: >>>> > > I think it's a great leap sideways, but I've done cp /dev/null foo >>>> to >>>> > > clear >>>> > > it out for 35 years now... It's why it feels like a workaround. >>>> > > >>>> > > Though it is a legit optimization, no matter the feelings. As for >>>> > > clearer, >>>> > > I'm less sure since then I have to remember what the : operator >>>> does. >>>> > > >>>> > > Warner >>>> > > >>>> > >>>> > For me, :> is idiomatic (but ugly). >>>> > >>>> > On the other hand, the cp /dev/null had a nice dogfooding aspect to >>>> > it... when we broke cp by accident, its use in the build system was >>>> the >>>> > first alarm to go off. >>>> > >>>> > --Ian >>>> > >>>> >>>> To be honest, this is a case that really should be covered by >>>> regression tests somewhere. >>>> >>> >>> It should (but isn't yet). >>> >>> Ian is right for old-school FreeBSD thinking. In that thinking the build >>> system should use an eclectic mix of tools to act as a fire-wall against >>> accidental breakage. >>> >>> Complete, effective, test suites give much better coverage... if they >>> are run... >>> >>> So until we run tests frequently, with loud regression squawking that's >>> as effective as build breakage, I tend to fall in the 'all of the above' >>> camp until that's in place... :) >>> >>> Warner >>> >>> P.S. though not, if I suppose, if it means that we're slowing down the >>> regression coverage uptake... >>> >> >> -- >> >> The test build was fine, please confirm if I can commit it or if someone >> else would like to write the UPDATING notice or start bootstrapping cp on >> systems that were affected. I'm not comfortable with not taking any path at >> all here, but this is a lot of friction for a small mechanical change to >> ease the pain. >> > > Sorry if I wasn't clear: I'm not objecting to the quick mechanical change > so much as complaining that I wish we had better test coverage. Don't let > that stop you from doing what's right (or I can if you'd like). > > Warner >