From owner-svn-src-head@freebsd.org Thu Jul 5 16:33:45 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3AAD3103B29D; Thu, 5 Jul 2018 16:33:45 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C453F86E6A; Thu, 5 Jul 2018 16:33:44 +0000 (UTC) (envelope-from brooks@spindle.one-eyed-alien.net) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 898AF5A9F17; Thu, 5 Jul 2018 16:33:38 +0000 (UTC) Date: Thu, 5 Jul 2018 16:33:38 +0000 From: Brooks Davis To: Ravi Pokala Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335979 - in head: . lib/libkvm sys/kern sys/netinet sys/sys usr.bin/netstat usr.bin/sockstat Message-ID: <20180705163338.GA67089@spindle.one-eyed-alien.net> References: <201807051313.w65DDnQJ041281@repo.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="UlVJffcvxoiEqYs2" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Jul 2018 16:33:45 -0000 --UlVJffcvxoiEqYs2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 05, 2018 at 09:10:54AM -0700, Ravi Pokala wrote: > Hi Brooks, >=20 > -----Original Message----- > From: on behalf of Brooks Davis > Date: 2018-07-05, Thursday at 06:13 > To: , , > Subject: svn commit: r335979 - in head: . lib/libkvm sys/kern sys/netinet= sys/sys usr.bin/netstat usr.bin/sockstat >=20 > > Author: brooks > > Date: Thu Jul 5 13:13:48 2018 > > New Revision: 335979 > > URL: https://svnweb.freebsd.org/changeset/base/335979 > >=20 > > Log: > > Make struct xinpcb and friends word-size independent. > > =20 > > Replace size_t members with ksize_t (uint64_t) and pointer members > > (never used as pointers in userspace, but instead as unique > > idenitifiers) with kvaddr_t (uint64_t). This makes the structs > > identical between 32-bit and 64-bit ABIs. > ... > > Modified: head/UPDATING > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/UPDATING Thu Jul 5 11:50:59 2018 (r335978) > > +++ head/UPDATING Thu Jul 5 13:13:48 2018 (r335979) > > @@ -31,6 +31,14 @@ NOTE TO PEOPLE WHO THINK THAT FreeBSD 12.x IS SLOW: > > disable the most expensive debugging functionality run > > "ln -s 'abort:false,junk:false' /etc/malloc.conf".) > > =20 > > +20180705: > > + The ABI of syscalls used by management tools like sockstat and > > + netstat has been broken to allow 32-bit binaries to work on > > + 64-bit kernels without modification. >=20 > Isn't that what the compat32 layer is for? compat32 isn't magic. If one tried, one could hardly design structures to make 32-bit compat harder then the previous versions. It's certainly possible to make work, but quite annoying. Since the ABI of most these structures was already broken for 12, I chose this approach as it is quite trivial. > > These programs will need > > + to match the kernel in order to function. External programs may > > + require minor modifications to accommodate a change of type in > > + structures from pointers to 64-bit virtual addresses. >=20 > Doesn't this contradict the earlier statement about letting things run un= modified? Unmodified post this commit. We already don't support netstat and sockstat from 11 on 12 in any architecture combination. -- Brooks --UlVJffcvxoiEqYs2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJbPkhhAAoJEKzQXbSebgfAo18H/AlCg0VMBICtPMoLdwCn73Cc agUY15e/YUZbW9opHKUkdvr/xXz9vQVHGfHC2rXGhha1HJ3mhFizp2E6LR0GBMzc JOwDkukmEfFIDnn9UPCgYyd7b75GHcZ5kX5qgmLYTZ3U+ODxqlFkkWSa/c55VGqO Ie3xz9q4pfGDGPhB3eUaIj/bR682DmmhgzJNcdado7wGOISu/dvUfWbF/R8OmixQ dXJGe1G33KaEgtAsTCVD9Vk6xHgsjLhVr7juhbaEDZwpXEz6QEEjJpVn9PQUP4xQ B+NTAoVzQ+38758WX7NRQBEFXoUlDWnCCgLGxrA3igypOT6/mTSgeFstmBmtk1A= =qcVb -----END PGP SIGNATURE----- --UlVJffcvxoiEqYs2--