From owner-svn-src-head@freebsd.org Thu Mar 30 23:39:20 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EBB71D26631; Thu, 30 Mar 2017 23:39:20 +0000 (UTC) (envelope-from David.Somayajulu@cavium.com) Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0077.outbound.protection.outlook.com [104.47.33.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client CN "mail.protection.outlook.com", Issuer "Microsoft IT SSL SHA2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 851EEF01; Thu, 30 Mar 2017 23:39:19 +0000 (UTC) (envelope-from David.Somayajulu@cavium.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=p2lQSkeie4tVILr+8alO+8bujutriC6OEWk+UZAVzic=; b=NpA5sVTrmjT+j/ZeQQtqAfP+wjkuNj8PfEMKJLdwHJ3Jpn0pmXtfwmOpKouqaSzAgDKlVICQ4Zo27QJzYiT8ZAX0CvAPRMlYXdtUoZ8hpnsiM2TUV3c6AUP6jTuPJDup547kh/m6kDiNIgjBZx9jG1dz9siCFgNENmsVRMoD+z0= Received: from BY2PR07MB1474.namprd07.prod.outlook.com (10.162.76.152) by BY2PR07MB1474.namprd07.prod.outlook.com (10.162.76.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.977.11; Thu, 30 Mar 2017 23:39:16 +0000 Received: from BY2PR07MB1474.namprd07.prod.outlook.com ([10.162.76.152]) by BY2PR07MB1474.namprd07.prod.outlook.com ([10.162.76.152]) with mapi id 15.01.0977.021; Thu, 30 Mar 2017 23:39:16 +0000 From: "Somayajulu, David" To: hiren panchasara CC: David C Somayajulu , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: RE: svn commit: r316309 - head/sys/dev/qlxgbe Thread-Topic: svn commit: r316309 - head/sys/dev/qlxgbe Thread-Index: AQHSqadk1yJwSnN9yEeerdOGAow+7qGuABeAgAAAWVCAAAJQAIAABJzA Date: Thu, 30 Mar 2017 23:39:16 +0000 Message-ID: References: <201703302243.v2UMhX2s011405@repo.freebsd.org> <20170330230227.GH1016@strugglingcoder.info> <20170330231158.GI1016@strugglingcoder.info> In-Reply-To: <20170330231158.GI1016@strugglingcoder.info> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: strugglingcoder.info; dkim=none (message not signed) header.d=none;strugglingcoder.info; dmarc=none action=none header.from=cavium.com; x-originating-ip: [198.186.0.2] x-microsoft-exchange-diagnostics: 1; BY2PR07MB1474; 7:6m75PpSEXKUiOdNi6C2bY2fd3LW4s6E0NoslPXYqfy9c44CeNso9tLjGtXc5fxqnu3fpwVrZAT7EEwkNAZX53GNAoNATwW12C+vL1XUjzrgAe1Vq0aW/O7H7Bi9uNq7fM5b5WswN8Vi67IXXZT2BGcbEefkVLm/rGnBCgjMpTgAk2zx1hxn1nu6Nt+07SgCzB101n2J2KNyuILclG8UtDYF+F5Elo+2thDrr3JNfynddbCXHnMamj/3iiZUGzyaqHfNeNLE2E0SkbUlyqyGbCa3iQTP/kETkNqX/MSU8XE4DrKF18mpfCEJFrW7ttDJzeMXEzFanx5X6SFkZ9pKW2g== x-ms-office365-filtering-correlation-id: a71e87c9-6d12-4123-3ae1-08d477c5fadf x-microsoft-antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(2017030254075)(201703131423075)(201703031133081)(201702281549075); SRVR:BY2PR07MB1474; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123564025)(6072148); SRVR:BY2PR07MB1474; BCL:0; PCL:0; RULEID:; SRVR:BY2PR07MB1474; x-forefront-prvs: 02622CEF0A x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(6009001)(39850400002)(39450400003)(39410400002)(39840400002)(39400400002)(24454002)(377454003)(13464003)(4326008)(86362001)(7696004)(76176999)(66066001)(54356999)(74316002)(2906002)(50986999)(6916009)(3280700002)(305945005)(93886004)(7736002)(3660700001)(2950100002)(33656002)(9686003)(55016002)(99286003)(54906002)(53936002)(189998001)(122556002)(229853002)(110136004)(38730400002)(77096006)(6246003)(6506006)(2900100001)(6436002)(81166006)(53546009)(8936002)(8676002)(102836003)(6116002)(5660300001)(3846002)(25786009); DIR:OUT; SFP:1101; SCL:1; SRVR:BY2PR07MB1474; H:BY2PR07MB1474.namprd07.prod.outlook.com; FPR:; SPF:None; MLV:sfv; LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Mar 2017 23:39:16.5403 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY2PR07MB1474 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 30 Mar 2017 23:39:21 -0000 >> > I know this is not a new topic but a little more descriptive commit-lo= g would have been nicer. Also, you should update the manpage reflecting thi= s change. i.e. now it also supports software LRO when h/w LRO is disabled. >> Will do. Sorry about that. Minor correction. Please note that the driver provides the ability to choos= e between SoftwareLRO and HW LRO, when LRO is enabled - it is HW LRO by def= ault. If LRO is turned off via ifconfig, neither Software nor HW LRO is ena= bled. Cheers David S. -----Original Message----- From: hiren panchasara [mailto:hiren@strugglingcoder.info]=20 Sent: Thursday, March 30, 2017 4:12 PM To: Somayajulu, David Cc: David C Somayajulu ; src-committers@freebsd.org; s= vn-src-all@freebsd.org; svn-src-head@freebsd.org Subject: Re: svn commit: r316309 - head/sys/dev/qlxgbe On 03/30/17 at 11:07P, Somayajulu, David wrote: > Hi Hiren, > > I know this is not a new topic but a little more descriptive commit-log= would have been nicer. Also, you should update the manpage reflecting this= change. i.e. now it also supports software LRO when h/w LRO is disabled. > Will do. Sorry about that. Thanks! >=20 > > Do you know of a case where one would want to disable h/w lro and enabl= e s/w lro? I guess where you want to free up nic and make cpu do more work? > I was under the impression as well, that s/w lro is moot, if h/w lro was = available, till one costumer asked for it. Not sure what the use case is. I thought this idea (like gro in linux) was popular when lro in h/w was con= sidered buggy and couldn't correctly do batching (i.e. hide useful flags). = Not sure if that's still the case. cheers, Hiren