Date: Wed, 05 Sep 2012 22:35:50 +0200 From: Florian Smeets <flo@smeets.im> To: Doug Barton <dougb@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r303626 - head/www/xpi-firebug Message-ID: <5047B7A6.8040601@smeets.im> In-Reply-To: <50462DEC.3040202@FreeBSD.org> References: <201209032233.q83MXSa2053725@svn.freebsd.org> <50453146.2080707@smeets.im> <504537D2.5050608@FreeBSD.org> <50454279.4020309@smeets.im> <50457770.4060402@FreeBSD.org> <5045E904.5080608@smeets.im> <50462DEC.3040202@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9059A5EA1C9C8721FF219EE5 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 04.09.12 18:35, Doug Barton wrote: > On 9/4/2012 4:41 AM, Florian Smeets wrote: >=20 >> I still see this as a style nit. Can you be a bit more specific where >> portmaster fails with distinfo (or other files) not having the last >> newline? >=20 > I already explained it twice. :) >=20 > Take a file with no newline at the end. Do this: >=20 > while read line ; do > echo $line > done < badfile >=20 > The last line will not be "seen" by the shell because of the missing > newline. Yes, that is pretty clear. >=20 > Portmaster, and other tools, use this method extensively to read those > files, and this issue causes those tools to break while processing thos= e > files. >=20 You keep repeating this, without proof. This is what I do not see, and you so conveniently stripped that part out of your reply. portmaster does not break for me when there is a missing newline at the end of distinfo. It updates the port happily. This is what i meant with being more specific, how can the failure be reproduced? It seems most of this will be moot soon anyway, so maybe we should just let this case rest. However someone should perhaps fix all the files that have been added without newline at the end of the file. Florian --------------enig9059A5EA1C9C8721FF219EE5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iEYEARECAAYFAlBHt6cACgkQapo8P8lCvwnS2gCgkHifiNdsAbesEBsJYGJa2GpN zh0AniBSz0UIcRAmuETeuChP0o7YTlsq =Px6/ -----END PGP SIGNATURE----- --------------enig9059A5EA1C9C8721FF219EE5--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5047B7A6.8040601>