From owner-freebsd-current@FreeBSD.ORG  Fri Dec 23 21:01:39 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 8E2D1106564A
	for <freebsd-current@freebsd.org>; Fri, 23 Dec 2011 21:01:39 +0000 (UTC)
	(envelope-from lists@eitanadler.com)
Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com
	[209.85.215.54])
	by mx1.freebsd.org (Postfix) with ESMTP id 0C6E88FC14
	for <freebsd-current@freebsd.org>; Fri, 23 Dec 2011 21:01:38 +0000 (UTC)
Received: by lahl5 with SMTP id l5so5424578lah.13
	for <freebsd-current@freebsd.org>; Fri, 23 Dec 2011 13:01:37 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
	d=eitanadler.com; s=0xdeadbeef;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type:content-transfer-encoding;
	bh=MOHizj4v/kmrpOACCeUCZah2edksTPybinykcDLYkdY=;
	b=i6hVw/jym923mX78usAuzETnwWxz8Oa+m5YsxebOxeELRLCjPIyO+U8nd/sc+fHPOY
	1SBvkRQ6Zipn40hL3DM+mS8VSB/ou0NVRwDFKeSXHH5ciob01absnKp4BsTYTDMZ6cEZ
	knK4anaCqhjYWqUAZE7yFGcrBNdEqgNkkh9yQ=
Received: by 10.152.128.196 with SMTP id nq4mr13843383lab.35.1324674097093;
	Fri, 23 Dec 2011 13:01:37 -0800 (PST)
MIME-Version: 1.0
Received: by 10.152.129.8 with HTTP; Fri, 23 Dec 2011 13:01:06 -0800 (PST)
In-Reply-To: <DED3F527-DD1F-4996-81EF-E3F30ED3E606@cederstrand.dk>
References: <DED3F527-DD1F-4996-81EF-E3F30ED3E606@cederstrand.dk>
From: Eitan Adler <lists@eitanadler.com>
Date: Fri, 23 Dec 2011 16:01:06 -0500
Message-ID: <CAF6rxgn+Ua7=3kkxr7bKtTe0pK-0L7Mc6D9srucP_Dd3OhHd8Q@mail.gmail.com>
To: Erik Cederstrand <erik@cederstrand.dk>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Cc: FreeBSD Current <freebsd-current@freebsd.org>
Subject: Re: GCC debug flags cleanup
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 23 Dec 2011 21:01:39 -0000

On Thu, Dec 22, 2011 at 6:52 AM, Erik Cederstrand <erik@cederstrand.dk> wro=
te:
> Hi,
>
> I've created a patch that cleans up FreeBSD Makefiles that unconditionall=
y set the -g flag for GCC. The motivation for this is that it should be pos=
sible to add or remove this flag globally via e.g. CFLAGS (it's part of my =
quest to produce deterministic builds).
>
> I'm not very familiar with GCC or the build infrastructure, so I'd be gra=
teful if someone would review it and possibly commit.
>
> http://dev.affect-it.dk/gcc_debug_flags.diff

Generally include your patches inline, it makes reviewing them easier.

Index: sys/amd64/conf/GENERIC
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- sys/amd64/conf/GENERIC  (revision 228312)
+++ sys/amd64/conf/GENERIC  (working copy)
@@ -21,7 +21,7 @@
...
-makeoptions    DEBUG=3D-g        # Build kernel with gdb(1) debug symbols

...

This is intentionally left in the config files. This is where the
.symbols file comes from in /boot/kernel/.



--=20
Eitan Adler