From owner-svn-src-all@freebsd.org Tue Apr 17 18:24:48 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3C47DF90080; Tue, 17 Apr 2018 18:24:48 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D90BD731AE; Tue, 17 Apr 2018 18:24:47 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from ralph.baldwin.cx (ralph.baldwin.cx [66.234.199.215]) by mail.baldwin.cx (Postfix) with ESMTPSA id 0409510AFD3; Tue, 17 Apr 2018 14:24:47 -0400 (EDT) From: John Baldwin To: Warner Losh Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332652 - in head/sys: conf dev/puc modules/puc Date: Tue, 17 Apr 2018 10:20:56 -0700 Message-ID: <3010482.A3g1Uy1uGA@ralph.baldwin.cx> User-Agent: KMail/4.14.10 (FreeBSD/11.1-STABLE; KDE/4.14.30; amd64; ; ) In-Reply-To: <201804171646.w3HGk9vn040646@repo.freebsd.org> References: <201804171646.w3HGk9vn040646@repo.freebsd.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Tue, 17 Apr 2018 14:24:47 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 18:24:48 -0000 On Tuesday, April 17, 2018 04:46:09 PM Warner Losh wrote: > Author: imp > Date: Tue Apr 17 16:46:08 2018 > New Revision: 332652 > URL: https://svnweb.freebsd.org/changeset/base/332652 > > Log: > Add PNP info to the PCI attahement of the puc driver. > > Adjust sys/conf/files and sys/modules/puc/Makefile to omit > pucdata.c now tht it's included by puc_pci.c. > > Submitted by: Lakhan Shiva Kamireddy (with build fixes by me) > Pull Request: https://github.com/freebsd/freebsd/pull/136 If you are going to #include it you can remove the terminator entry and use nitems() in puc_pci_match instead. That will also remove the need for the - 1 hack in the MODULE_PNP_INFO line. -- John Baldwin