From owner-freebsd-fs@FreeBSD.ORG  Sat Jun 20 23:22:38 2015
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id E0463E9B
 for <freebsd-fs@hub.freebsd.org>; Sat, 20 Jun 2015 23:22:38 +0000 (UTC)
 (envelope-from rmacklem@uoguelph.ca)
Received: from esa-jnhn.mail.uoguelph.ca (esa-jnhn.mail.uoguelph.ca
 [131.104.91.44]) by mx1.freebsd.org (Postfix) with ESMTP id A92043F1
 for <freebsd-fs@freebsd.org>; Sat, 20 Jun 2015 23:22:38 +0000 (UTC)
 (envelope-from rmacklem@uoguelph.ca)
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: A2ABBACF9IVV/95baINcg2RfBoMYumcJgVwKhS5KAoFbFAEBAQEBAQGBCoQiAQEBAwEBAQEgKyALBRYYAgINGQIpAQkmBggHBAEcBIgGCA2wUZV2AQEBAQEFAQEBAQEBAQEagSGKJIQ0AQEFFzQHgmiBQwWTfYRWhC+ERIt0ikImY4FZgVkiMQeBBTqBAgEBAQ
X-IronPort-AV: E=Sophos;i="5.13,651,1427774400"; d="scan'208";a="217618327"
Received: from muskoka.cs.uoguelph.ca (HELO zcs3.mail.uoguelph.ca)
 ([131.104.91.222])
 by esa-jnhn.mail.uoguelph.ca with ESMTP; 20 Jun 2015 19:22:37 -0400
Received: from zcs3.mail.uoguelph.ca (localhost.localdomain [127.0.0.1])
 by zcs3.mail.uoguelph.ca (Postfix) with ESMTP id 7D409B3FB3;
 Sat, 20 Jun 2015 19:22:37 -0400 (EDT)
Date: Sat, 20 Jun 2015 19:22:37 -0400 (EDT)
From: Rick Macklem <rmacklem@uoguelph.ca>
To: "alex.burlyga.ietf alex.burlyga.ietf" <alex.burlyga.ietf@gmail.com>
Cc: freebsd-fs@freebsd.org
Message-ID: <154571553.61423606.1434842557502.JavaMail.root@uoguelph.ca>
In-Reply-To: <CA+JhTNTSC-xPVdpUGcQemVMLUwuQB6D8-3d2HD6WjU+jd1SMNQ@mail.gmail.com>
Subject: Re: [nfs][client] - Question about handling of the NFS3_EEXIST
 error in SYMLINK rpc
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Originating-IP: [172.17.95.11]
X-Mailer: Zimbra 7.2.6_GA_2926 (ZimbraWebClient - FF3.0 (Win)/7.2.6_GA_2926)
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs/>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
 <mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 20 Jun 2015 23:22:39 -0000

Alex Burlyga wrote:
> Hi,
> 
> NFS client code in nfsrpc_symlink() masks server returned NFS3_EEXIST
> error
> code
> by returning 0 to the upper layers. I'm assuming this was an attempt
> to
> work around
> some server's broken replay cache out there, however, it breaks a
> more
> common
> case where server is returning EEXIST for legitimate reason and
> application
> is expecting this error code and equipped to deal with it.
> 
> To fix it I see three ways of doing this:
>  * Remove offending code
>  * Make it optional, sysctl?
>  * On NFS3_EEXIST send READLINK rpc to make sure symlink content is
>  right
> 
> Which of the ways will maximize the chances of getting this fix
> upstream?
> 
Btw, I felt #2 above was appropriate but forgot to ask what others
thought w.r.t. this?

Thanks, rick

> One more point, old client circa FreeBSD 7.0 does not exhibit this
> problem.
> 
> Alex
> _______________________________________________
> freebsd-fs@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-fs
> To unsubscribe, send any mail to "freebsd-fs-unsubscribe@freebsd.org"
>